security(ci): pin GitHub Actions to commit SHAs and fix template injection - #322
Merged
Conversation
…ction zizmor's mandatory checks (unpinned-uses, template-injection) started failing on dependabot PRs that touch workflow files. Pin all actions to a commit SHA (with the version as a trailing comment) and pass the release-please version through env instead of interpolating it directly into the release.yml shell script.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uses:action references incodeql.yml,java.yml,publish-docs.yml, andrelease.ymlto a commit SHA (with the version tag kept as a trailing comment), per zizmor'sunpinned-usesmandatory check.template-injectionfinding inrelease.ymlby passingneeds.release.outputs.versionthroughenvinstead of interpolating it directly into therun:shell script.This was blocking dependabot PR #316 (
actions/setup-java5→6) — theGitHub Actions Scan/ zizmor job fails on any PR that touches a workflow file, and it flags every workflow file's existing unpinned actions, not just the diff.Test plan
GitHub Actions Scanshould go green)