Repository navigation
Conversation
Skip tracing HTTP OPTIONS requests by default in v9 to avoid creating transactions for CORS preflight traffic. Applications can opt back in with traceOptionsRequests. Fixes #4163 Co-Authored-By: Codex <noreply@openai.com>
Contributor
|
1 of 6 tasks
📲 Install BuildsAndroid
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Change
traceOptionsRequeststo default tofalsein version 9 and add a regression test for the new default.Applications that need transactions for HTTP
OPTIONSrequests can continue to opt in by setting the option totrue.💡 Motivation and Context
OPTIONSrequests are commonly CORS preflight traffic and generally do not provide useful tracing data. Version 9 is the breaking-change boundary for aligning the Java SDK with the tracing specification, which defines this option as disabled by default.Resolves #4163
💚 How did you test it?
./gradlew spotlessApply apiDump./gradlew ':sentry:test' --tests="*SentryOptionsTest*" --info(143 tests passed)📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Update the version 9 Java and Android option documentation in
sentry-docs.