Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
`logsEnabled` argument. The deprecated constructor without `minimumLevel` is removed.
- Manually constructed `SentryTimberIntegration` and `SentryTimberTree` instances require a
`logsEnabled` argument. Pass `false` to keep Sentry Logs disabled.
- Disable tracing for HTTP `OPTIONS` requests by default. Set `traceOptionsRequests` to `true` to
preserve the previous behavior ([#6254](https://github.com/getsentry/sentry-java/pull/6254))
- Remove the Apache HttpClient transport and stop publishing `sentry-apache-http-client-5` ([#6214](https://github.com/getsentry/sentry-java/pull/6214))

### Features
Expand Down
3 changes: 1 addition & 2 deletions sentry/src/main/java/io/sentry/SentryOptions.java
Original file line number Diff line number Diff line change
Expand Up @@ -517,9 +517,8 @@ public class SentryOptions implements RateLimiterConfig {

private @NotNull IThreadChecker threadChecker = NoOpThreadChecker.getInstance();

// TODO [MAJOR] this should default to false on the next major
/** Whether OPTIONS requests should be traced. */
private boolean traceOptionsRequests = true;
private boolean traceOptionsRequests = false;

/** Whether database transaction spans (BEGIN, COMMIT, ROLLBACK) should be traced. */
private boolean enableDatabaseTransactionTracing = false;
Expand Down
5 changes: 5 additions & 0 deletions sentry/src/test/java/io/sentry/SentryOptionsTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,11 @@ class SentryOptionsTest {
assertFalse(options.isTracingEnabled)
}

@Test
fun `traceOptionsRequests defaults to false`() {
assertThat(SentryOptions().isTraceOptionsRequests).isFalse()
}

@Test
fun `when there's no cacheDirPath, outboxPath returns null`() {
val options = SentryOptions()
Expand Down
Loading