Repository navigation
fix(boto3): remove space from service_id and span names - #7955
Merged
Merged
Conversation
pabloDeputter
marked this pull request as ready for review
October 12, 2026 11:17
Contributor
Codecov Results 📊✅ 55565 passed | ⏭️ 2872 skipped | Total: 58437 | Pass Rate: 95.09% | Execution Time: 155m 39s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2067 uncovered lines. Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.28% 90.10% -0.18%
==========================================
Files 202 193 -9
Lines 26625 20886 -5739
Branches 9926 7206 -2720
==========================================
+ Hits 24039 18819 -5220
- Misses 2586 2067 -519
- Partials 1515 1237 -278Generated by Codecov Action |
alexander-alderman-webb
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove whitespace from services whose
service_idcontain spaces; since span names are formed usingstr(service_id)they are incorrect:service_id = "API Gateway"=>service_id= "API Gateway"span_name = "API Gateway.GetRestApis"=>span_name = "APIGateway.GetRestApis"Issues
Resolves #7954