Skip to content

fix(boto3): remove space from service_id and span names - #7955

Merged
pabloDeputter merged 1 commit into
major/3.0from
pablo/fix-boto3-span-names
Oct 12, 2026
Merged

pabloDeputter merged 1 commit into
major/3.0from
pablo/fix-boto3-span-names

Conversation

@pabloDeputter

Copy link
Copy Markdown
Member

Description

Remove whitespace from services whose service_id contain spaces; since span names are formed using str(service_id) they are incorrect:

  • service_id = "API Gateway" => service_id= "API Gateway"
  • span_name = "API Gateway.GetRestApis" => span_name = "APIGateway.GetRestApis"

Issues

Resolves #7954

@pabloDeputter
pabloDeputter marked this pull request as ready for review October 12, 2026 11:17
@pabloDeputter
pabloDeputter requested a review from a team as a code owner October 12, 2026 11:17
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 55565 passed | ⏭️ 2872 skipped | Total: 58437 | Pass Rate: 95.09% | Execution Time: 155m 39s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -79231
Passed Tests 📉 -74825
Failed Tests 📉 -2
Skipped Tests 📉 -4404

➖ Removed Tests (1)

View removed tests
  • test_binary_content_encoding_mixed_content[False-False]
    • File: tests.integrations.litellm.test_litellm

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2067 uncovered lines.
❌ Project coverage is 90.1%. Comparing base (c27c69a) to head (569a7f9).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.28%    90.10%    -0.18%
==========================================
  Files          202       193        -9
  Lines        26625     20886     -5739
  Branches      9926      7206     -2720
==========================================
+ Hits         24039     18819     -5220
- Misses        2586      2067      -519
- Partials      1515      1237      -278

Generated by Codecov Action

@pabloDeputter
pabloDeputter merged commit 906879f into major/3.0 Oct 12, 2026
147 checks passed
@pabloDeputter
pabloDeputter deleted the pablo/fix-boto3-span-names branch October 12, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants