Skip to content

fix(boto3): remove space from service_id and span names #7955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pabloDeputter merged 1 commit into from
Oct 12, 2026
Merged

fix(boto3): remove space from service_id and span names #7955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sentry_sdk/integrations/boto3/_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ def add_metadata(self, client: "BaseClient") -> None:
# botocore's internal identifier, e.g. `apigateway`.
self.service_name = service_model.service_name
service_id = service_model.service_id
# modeled AWS service identity used in span names, e.g. `API Gateway`.
self.service_id = str(service_id)
# modeled AWS service identity used in span names with whitespace stripped, e.g. `API Gateway` => `APIGateway`.
self.service_id = "".join(str(service_id).split())
self.service_id_hyphenized = service_id.hyphenize()

with capture_internal_exceptions():
Expand Down
4 changes: 2 additions & 2 deletions tests/integrations/boto3/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,8 +540,8 @@ def get_response_attributes(self, ctx, response):
"apigateway",
"get_rest_apis",
{},
"API Gateway.GetRestApis",
"API Gateway",
"APIGateway.GetRestApis",
"APIGateway",
"GetRestApis",
None,
"apigateway.eu-north-1.amazonaws.com",
Expand Down
Loading