Repository navigation
feat(types): export Attributes from the public types module - #8019
Merged
Merged
Conversation
Comment on lines
+9
to
+12
| def test_attributes_optional_runtime(): | ||
| from sentry_sdk.types import Attributes | ||
|
|
||
| Optional[Attributes] |
Collaborator
There was a problem hiding this comment.
Not sure what this test is doing, can remove
Contributor
Author
There was a problem hiding this comment.
I've removed the test and pushed the update
sentrivana
approved these changes
Oct 13, 2026
Collaborator
|
LGTM, thanks! |
sentrivana
enabled auto-merge (squash)
October 13, 2026 12:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expose
Attributesfromsentry_sdk.typesso callers can annotate span attributes without importing the privatesentry_sdk._typesmoduleThe export follows the existing public type pattern:
Anyfallback for runtime annotation importsAttributesin__all__This is a three-line change in
sentry_sdk/types.py. No test files are changedThe internal type definition remains unchanged. No dependencies or configuration changes are needed
Validation
Local checks run on Windows with Python 3.12:
tests/test_types.py: 2 existing tests passedAttributesimport checked at runtimegit diff --checkpassedThe full integration matrix has not been run locally. GitHub's CI and Test workflows currently report
action_required; no jobs have runAI assistance was used for implementation and local validation
Issues
Attributestype definition in public place #6970Reminders
uv run ruff.feat:,fix:,ref:,meta:)