Skip to content

Fix Linux source archive dependency cleanup - #250

Merged
drebbe-intrepid merged 1 commit into
masterfrom
codex/fix-248-linux-build-clean
Sep 16, 2026
Merged

drebbe-intrepid merged 1 commit into
masterfrom
codex/fix-248-linux-build-clean

Conversation

@drebbe-intrepid

Copy link
Copy Markdown
Collaborator

Linux builds from source archives fail because git clean runs outside the nested dependency checkout. Clean and recreate only LIBICSNEO_BUILD, preserving dependency sources, installation files, and the protobuf bootstrap cache.

Fixes #248.

Validation:

  • Reproduced the original Git exit 128 using a temporary archive-style tree and a real nested Git checkout.
  • Three regression tests pass on Windows CPython 3.12 and WSL Ubuntu: fresh archive-style build, scoped rebuild cleanup/preservation, and cleanup-error propagation. CMake calls are stubbed; no full source compilation or hardware tests were run.
  • git diff --check passes.
  • Broader unittest discovery cannot import the unbuilt ics extension in this fresh worktree (six import errors).

Independent critic /root/critic explicitly agreed with the final two-file diff: "I agree with the final diff for issue #248. No required corrections." Builder also explicitly agrees. Reviewed content is committed as 2d0eb35.

@drebbe-intrepid
drebbe-intrepid merged commit c392491 into master Sep 16, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2] Linux source builds fail when git clean runs outside the dependency checkout

1 participant