Fix Windows in-place rebuild locking its existing extension - #262
Open
drebbe-intrepid wants to merge 1 commit into
Open
drebbe-intrepid wants to merge 1 commit into
drebbe-intrepid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows in-place rebuilds imported the existing extension twice before attempting to replace it: generated-structure validation and setuptools dynamic version lookup. Run validation in a checked subprocess that exits before copying the extension, and read the generated version literal directly.
Adds six regression cases for child-process isolation, import failures, regeneration, and metadata lookup, plus two consecutive forced in-place builds in Windows CI.
Validation (Windows x64, CPython 3.14.5):
python setup.py build_ext --inplace --forcecommands pass after the fix.python setup.py build_py, thenPYTHONPATH=gen python -m pytest tests -q: 36 passed./root/criticagrees with final five-file diff; builder agrees. Critic independently ran all six regression tests and inspected build logs.Fixes #249