Skip to content

fix: remove release-please cargo workspace plugin#68

Merged
archae0pteryx merged 1 commit into
mainfrom
fix/release-please-workspace-version
May 20, 2026
Merged

fix: remove release-please cargo workspace plugin#68
archae0pteryx merged 1 commit into
mainfrom
fix/release-please-workspace-version

Conversation

@archae0pteryx

@archae0pteryx archae0pteryx commented May 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove the Release Please cargo-workspace plugin, which fails on this repo's version.workspace = true member manifests
  • keep the root Rust strategy and explicit npm/Tauri extra files intact

Why

The first main run failed with:

release-please failed: cargo-workspace (killallgit/adhd-ranch): package manifest at src-tauri/Cargo.toml has an invalid [package.version]

Release Please had already detected the Rust workspace and calculated the next version before the plugin ran, so the plugin is redundant here.

Verification

  • rtk node -e "for (const f of ['release-please-config.json','.release-please-manifest.json']) JSON.parse(require('fs').readFileSync(f, 'utf8')); console.log('release-please json ok')"

Summary by CodeRabbit

  • Chores
    • Simplified release configuration by streamlining settings.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0b24dcc2-ace3-4f43-bd78-ad4a686a5f87

📥 Commits

Reviewing files that changed from the base of the PR and between 89a58bf and 42db619.

📒 Files selected for processing (1)
  • release-please-config.json
💤 Files with no reviewable changes (1)
  • release-please-config.json

📝 Walkthrough

Walkthrough

The plugins configuration block was removed from release-please-config.json. The cargo-workspace plugin setup with updateAllPackages: true is no longer present, allowing the configuration to proceed directly from include-component-in-tag to packages.

Changes

Release Configuration Update

Layer / File(s) Summary
Remove cargo-workspace plugin configuration
release-please-config.json
Deleted the top-level plugins block containing cargo-workspace configuration with updateAllPackages: true setting, simplifying the release configuration structure.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A plugin shed like morning dew,
Config lighter, simpler too,
Packages flow in cleaner way,
Release-please brightens up the day! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: removing the cargo workspace plugin from the release-please configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-please-workspace-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@archae0pteryx
archae0pteryx merged commit 0b616ed into main May 20, 2026
2 checks passed
@archae0pteryx
archae0pteryx deleted the fix/release-please-workspace-version branch May 20, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant