test(providers): assemble the userinfo fixture instead of writing it inline - #5195
Conversation
…inline The OpenCode Go destination test added by #5165 carried an inline https URL with userinfo. privacy:scan reads source text, so its email detector saw the password and host as an address and failed the gates job on dev, blocking every branch that merged current dev. isAllowedEmail already carries one URL-userinfo exemption for a chatgpt.com fixture, so adding a second entry was available and is the wrong fix. That allowlist is what keeps the detector able to fail on a real address, and each entry spends a little of that. Assembling the URL through the username and password setters removes the literal entirely and leaves nothing to exempt. The input under test does not change. new URL with the same path and those two setters serializes to exactly the string it replaces, so the case still proves that a base URL carrying userinfo refuses the patient same-target fallback. No local suite, focused test, typecheck or build was run. Exact-head hosted CI is the execution evidence.
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
The OpenCode Go destination test added by #5165 carried an inline https URL with userinfo.
privacy:scanreads source text, so its email detector read the password and host as an address and failed thegatesjob ondev. That blocks every branch whose merge ref includes currentdev, not just this test.isAllowedEmailinscripts/privacy-scan.tsalready carries one URL-userinfo exemption for achatgpt.comfixture, so adding a second entry was available and is the wrong fix. That allowlist is what keeps the detector able to fail on a real address, and every entry spends a little of that. Assembling the URL through theusernameandpasswordsetters removes the literal entirely and leaves nothing to exempt.The input under test does not change.
new URLwith the same path plus those two setters serializes to exactly the string it replaces, so the case still proves that a base URL carrying userinfo refuses the patient same-target fallback.Reported by the contract-campaign task, which hit it on its own merge ref in job 105937216310 and confirmed the literal is on
devrather than on its branch.Verification
ocxcommand, so no local result is claimed. Exact-head hosted CI is the executable evidence.isAllowedEmailto confirm the existing exemption shape and that widening it was the alternative being rejected; confirmed by inspection that the assembledhrefis byte-identical to the removed literal; confirmed no other occurrence of the pattern remains in the file.Checklist