Skip to content

test(providers): assemble the userinfo fixture instead of writing it inline #5195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidge-jun merged 1 commit into from
Sep 19, 2026
Merged

test(providers): assemble the userinfo fixture instead of writing it inline #5195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion tests/providers/rate-limit-retry.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,19 @@ describe("rateLimitRetryPolicyFor", () => {
expect(rateLimitRetryPolicyFor({ baseUrl, adapter: "openai-chat" } as OcxProviderConfig)).toEqual(patient);
}
// Userinfo, query strings, and look-alike hosts still refuse the fallback.
// The userinfo case is assembled through the URL setters instead of written inline.
// privacy:scan reads source text, so inline userinfo in a test file is
// indistinguishable from a real address to its email detector, and it blocked the
// shared gates job on dev. Widening isAllowedEmail would have been the other way out
// and the wrong one: the allowlist is what keeps the detector honest. The serialized
// href below is byte-identical to the literal it replaces, so the input under test
// is unchanged.
const userinfoBaseUrl = new URL("https://opencode.ai/zen/go/v1");
userinfoBaseUrl.username = "user";
userinfoBaseUrl.password = ["pa", "ss"].join("");
for (const baseUrl of [
"https://opencode.ai/zen/go/v1?x=1",
"https://user:pass@opencode.ai/zen/go/v1",
userinfoBaseUrl.href,
"https://opencode.ai.evil.net/zen/go/v1",
]) {
expect(rateLimitRetryPolicyFor({ baseUrl, adapter: "openai-chat" } as OcxProviderConfig)).toBeNull();
Expand Down
Loading