fix(lab): record that the Chat conformance destination accepts the developer role - #5341
Conversation
…veloper role #5334 folds the wire role unless a destination records acceptance. This vector is the one place that asserts the forwarded role, and it lives outside tests/, so the change missed it and dev went red with roles:value_mismatch.
|
Warning Review limit reachedNext included review available in 6 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
⏳ DRAFT
What to do
Automatic draft conversion failed (token cannot change draft status). Please convert this pull request to a draft manually. The required |
…ment suite lidge-jun#5334 made foldDeveloperRoleToSystem tri-state: unset now folds developer to system, and only an explicit false records a destination that accepts the role. This suite's chatProvider fixture declared nothing, so its developer-turn assertion folded and failed on the PR merge. Record acceptance, matching the conformance-fixture fix in lidge-jun#5341. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Summary
chat-core.protocol.request-mappingasserts that adevelopermessage reaches the Chat wire asdeveloper. fix(openai-chat): fold the developer role unless a destination records that it accepts it #5334 made the wire role fold tosystemunless a destination records that it accepts it, and this fixture records nothing, so the assertion started failing withroles:value_mismatchondevand on every branch cut from it.developer", andapi.openai.comdoes accept the role. The destination it stands for now records that, so the vector keeps testing what it was written to test.Verification
chat-core.protocol.request-mapping: protocol_failure deterministic_assertion roles:value_mismatchon shard 2/4 of run 35510777682.tests/; the otherrole: "developer"occurrences construct the internal representation that the adapter maps, and are unaffected.Checklist