Skip to content

fix(lab): record that the Chat conformance destination accepts the developer role - #5341

Merged
lidge-jun merged 1 commit into
devfrom
codex/260920-lab-fixture-developer-role
Sep 20, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/260920-lab-fixture-developer-role

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

  • The Lab conformance vector chat-core.protocol.request-mapping asserts that a developer message reaches the Chat wire as developer. fix(openai-chat): fold the developer role unless a destination records that it accepts it #5334 made the wire role fold to system unless a destination records that it accepts it, and this fixture records nothing, so the assertion started failing with roles:value_mismatch on dev and on every branch cut from it.
  • The fixture provider already states that it exercises native OpenAI Chat semantics "including role:developer", and api.openai.com does accept the role. The destination it stands for now records that, so the vector keeps testing what it was written to test.
  • No fixture bytes or digests change; only the provider the harness builds. The declaration is scoped to the Chat adapter, which is the only one that reaches the role decision.

Verification

  • The failure is reproduced by the exact assertion text in the hosted log: chat-core.protocol.request-mapping: protocol_failure deterministic_assertion roles:value_mismatch on shard 2/4 of run 35510777682.
  • A repository-wide search for wire-role expectations found this as the only remaining one outside tests/; the other role: "developer" occurrences construct the internal representation that the adapter maps, and are unaffected.
  • Local suites, typecheck and builds were not run in this lane; exact-head hosted CI on this pull request is the execution evidence.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

…veloper role

#5334 folds the wire role unless a destination records acceptance. This vector is the one place that asserts the forwarded role, and it lives outside tests/, so the change missed it and dev went red with roles:value_mismatch.
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 20, 2026 12:48
@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d2e2fcc3-125b-4213-8e6c-8a7ec220ac31

📥 Commits

Reviewing files that changed from the base of the PR and between d9cb0eb and 1552fee.

📒 Files selected for processing (1)
  • src/lab/conformance/fixture-provider.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lidge-jun
lidge-jun merged commit 600075d into dev Sep 20, 2026
7 of 8 checks passed
@lidge-jun
lidge-jun deleted the codex/260920-lab-fixture-developer-role branch September 20, 2026 12:48
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-20T12:51:12.192392Z 1552fee PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the intake: hygiene-blocked Deterministic PR hygiene checks failed label Sep 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Deterministic hygiene checks failed.

  • missing_regression_test — Behavior changed under src/ or gui/src/ without a test change. Add focused coverage or obtain test-exception-approved.

@github-actions github-actions Bot added the bug Something isn't working label Sep 20, 2026
@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • hygiene: missing_regression_test.

What to do

  • Fix missing_regression_test — Behavior changed under src/ or gui/src/ without a test change. Add focused coverage or obtain test-exception-approved.

Automatic draft conversion failed (token cannot change draft status). Please convert this pull request to a draft manually. The required enforce-target check will keep failing until every issue above is resolved.

devin-ai-integration Bot added a commit to luvs01/opencodex that referenced this pull request Sep 20, 2026
…ment suite

lidge-jun#5334 made foldDeveloperRoleToSystem tri-state: unset now folds developer to
system, and only an explicit false records a destination that accepts the role.
This suite's chatProvider fixture declared nothing, so its developer-turn
assertion folded and failed on the PR merge. Record acceptance, matching the
conformance-fixture fix in lidge-jun#5341.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working intake: hygiene-blocked Deterministic PR hygiene checks failed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants