Repository navigation
Conversation
JayceeB1
marked this pull request as ready for review
October 9, 2026 21:09
JayceeB1
added a commit
to JayceeB1/modly
that referenced
this pull request
Oct 9, 2026
…mental preview) Source: lightningpixel#370; preserves released Modly 0.4.3.
This was referenced Oct 9, 2026
Confirmed by combined CI regression. Remove only an empty target with rmdir; never remove source on copy failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safety hotfix (review/staging PR)
This is the same branch intended for a draft PR to
lightningpixel/modly:dev. The linked GitHub integration does not currently have permission to create a PR in that upstream repository (403). Opening the draft here preserves a reviewable diff while waiting for a normal cross-fork submission.Why
See upstream #351 (reported catastrophic data loss, not independently reproduced). Source inspection confirmed unguarded
copy → recursive deleteduring moves and unsafe rawstartsWithdeletion allow-list.Patch
fs:moveDirectoryandfs:deleteDirectoryinto fail-closed main-process guards.tmpcleanup and enable workflow storage deletion.Verification
No upstream code is changed by this PR. Please do not merge without the remaining validation.
Upstream #351: #351
Intended upstream PR comparison: dev...JayceeB1:modly:fix/storage-destructive-operations