feat(builder): support UPDATE FROM builders and preserve DML CTEs - #779
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #779 +/- ##
==========================================
+ Coverage 77.49% 78.91% +1.41%
==========================================
Files 489 491 +2
Lines 72169 72437 +268
Branches 10128 10181 +53
==========================================
+ Hits 55930 57163 +1233
+ Misses 13050 11767 -1283
- Partials 3189 3507 +318
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
cofin
added a commit
that referenced
this pull request
Sep 13, 2026
cofin
added a commit
that referenced
this pull request
Sep 13, 2026
cofin
added a commit
that referenced
this pull request
Sep 13, 2026
cofin
force-pushed
the
flow/builder-dml-cte-update-from
branch
2 times, most recently
from
September 13, 2026 20:15
c992a71 to
c1ff0e8
Compare
…n UPDATE and DELETE (#773)
cofin
force-pushed
the
flow/builder-dml-cte-update-from
branch
from
September 13, 2026 20:19
c1ff0e8 to
17a6f2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds query-builder and subquery sources to
Update.from_()with bound-parameter merging, and preserves explicit CTEs on UPDATE and DELETE throughwith_cte()/with_(). Dialect checks retain supported UPDATE FROM forms, including BigQuery, and reject unsupported forms withSQLBuilderError, including Spanner PostgreSQL mode.Adds the parameterized
sql.values()factory andValuesbuilder, with CTE bindings retained when queries are composed. Usesql.column("values")for a column with that name. Includes unit/integration regressions, documentation, and v0.63.0 release notes.Validation:
make lintpassed during review. Regression tests were added or updated, but no local test suite was run in this review. Hosted CI for the latest branch head is still pending.