Fix failed tests on Darwin - #267
Conversation
Signed-off-by: Federico Bruzzone <federico.bruzzone.i@gmail.com>
|
Kind ping: @rengolin @adam-smnk |
rengolin
left a comment
There was a problem hiding this comment.
Looks good, thanks! Do you want to address the final problem in a separate PR? If so, I'm happy to merge this.
Just need to understand the bash change. Neither solutions are good, mind you, and both play tricks with symlinks and how bash works across systems. So, if cd + pwd work on both cases, I'm happy with it.
@adam-smnk any strong opinion?
Thanks for the prompt response! :D
I'll send a PR in a moment. I thought it would take longer, but I almost fixed it'll be stacked on this one.
You're absolutely right, an alternative solution could be used: PROJECT_ROOT="$(python3 -c "from pathlib import Path; print(Path('$0').resolve().parent.parent.parent.parent)")"If you prefer, I'm happy to make the change. |
Signed-off-by: Federico Bruzzone <federico.bruzzone.i@gmail.com>
rengolin
left a comment
There was a problem hiding this comment.
Thanks! Is there a free Darwin builder in Github? We could setup a CI loop like we do for Arm and x86 Linux.
|
Not at all! :D |
|
Don't worry, PRs for new builders is a pain, I'll try to set up on a new branch and then merge to main when it's working. |
Hi folks, I'm new to Lighthouse! Thanks for your work :D
I think that it's a super cool project, not only for prototypes but also for eventual educational stuff.
I just set up the repo on Darwin (macOS M4 Pro).
After running
uv run lit .I got the following output:This PR aims to resolve them.
For the first three tests, other than minor fixes, it introduces
_get_feature_list_darwinby leveragingsysctl.Regarding
pipeline-check.mlir, the problem is relatively simple to fix. Currently,lighthouseassumes a.soextension for shared libs. Unfortunately, on macOS the extension is.dylib. This PR introduces the_SHARED_EXTvar to handle it properly.Please let me know whether this is welcome and if I can improve this submission 🫶