Standardize per-row action links across Data Health checks (#1405)#1406
Merged
Conversation
Every Data Health check now gives each flagged row an admin action link, so admins stay one click from the fix. Previously only 3 of 10 checks did. - HealthCheck base gains link_model / link_id_key attrs and a default row_link() that deep-links a row to its admin change page. - Wire the 7 linkless checks in: publication-quality, duplicate-people, news-health, project-health, project-leadership (default link), position-integrity (person_id key), and url-name-collisions (custom link to the Person changelist filtered by the offending url_name). - Add url_name to PersonAdmin.search_fields so that filtered link resolves. - Test pins that every registered check provides an action link. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of #1405 (link standardization). Part 2 (companion checks) is stacked on this branch in a follow-up PR.
What & why
The admin Data Health dashboard is meant to keep admins one click from the fix, but only 3 of 10 checks rendered a per-row Action link. The rest already carried the model's
id— they just never built the link. This makes action links universal.Changes
HealthCheckbase gainslink_model/link_id_keyattrs and a defaultrow_link()that deep-links each row to its admin change page.publication-quality,duplicate-people,news-health,project-health,project-leadership(default link);position-integrity(person_idkey);url-name-collisions(custom link to the Person changelist filtered by the offendingurl_name).url_nametoPersonAdmin.search_fieldsso that filtered?q=link resolves (also a sensible search improvement on its own).The 3 pre-existing custom links (
unlinked-artifacts,duplicate-keywords,media-integrity) are unchanged. No model/DB, view, or template changes — the detail template already renders the Action column generically viahas_links.Testing
python manage.py test website --settings=makeabilitylab.settings_test→ 576 passing (8 skipped).🤖 Generated with Claude Code