Repository navigation
fix(plannings): the day dialog shows pause start and stop to the second (#1741) - #1758
Merged
Merged
Conversation
…nd (#1741) The pause listing under each shift showed HH:mm, so a pause of a few seconds, or two pauses in the same minute, could not be read. It now shows the full HH:mm:ss of each stamp; a pause running past midnight ends at 24:00:00. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The formatting change is correct, focused, and covered across utility, component, and end-to-end tests.
0 open findings
What changed in this PR
Updates day-dialog pause ranges to display second-level timestamps.
Changes:
- Formats pause segments as
HH:mm:ss, including open and midnight-clamped pauses. - Updates unit and Playwright coverage for second-level timestamps.
| File | Description |
|---|---|
workday-entity-dialog.component.spec.ts |
Updates dialog expectations for seconds. |
pause-segments.util.ts |
Adds second-level pause formatting. |
pause-segments.util.spec.ts |
Covers seconds and same-minute pauses. |
day-dialog-pause-times.spec.ts |
Verifies seconds in the rendered dialog. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1749 (#1741).
The day dialog lists each shift's recorded pauses as
Pause HH:mm–HH:mm. That hides the seconds, so a short pause or two pauses in the same minute cannot be read. The listing now shows the full stamp:Pause 14:50:07–14:55:31.pause-segments.util.ts: segments are formattedHH:mm:ss. Merging and clamping already worked on whole seconds and are unchanged; a pause running past midnight ends at24:00:00.s/day-dialog-pause-times.spec.tspatches stamps with seconds and asserts10:02:40–10:17:10/12:30:00–12:45:00.Tests run in CI only.
🤖 Generated with Claude Code