Repository navigation
Untick chosen issues that a cleared or older pick no longer ships - #39
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks used to follow chosen issues in one direction only. Ticking an issue picked tags, but clearing a pick or picking an older tag by hand left the issue ticked. Clearing a pick also came back on reload: the address kept
issues=...and no picks, so the issue picks were applied again.Now a pick that misses a chosen issue unticks that issue. That covers clearing it with
×, picking an older tag, and loading an address whose picks miss an issue. Picks that only the unticked issue needed in other services are cleared as well, the same as when you untick it in the list. The hand pick stays.The "does not ship" warning (
missedBy,planMissed) can no longer show, so it is removed.Tests: three browser smoke tests cover the
×clear plus reload, an older hand pick, and an address with an older pick. All three failed before the fix.