Repository navigation
Test unticking an issue that spans services on the demo page - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #39. Its browser tests use the CLI fixture, which has a single service, so they never cover what happens to the other services when an issue is unticked. These three smoke tests run on the demo site, where SHOP-38 is picked in both
shop/api(2.5.0) andshop/web(1.9.0):shop/apipick with×unticks SHOP-38 and clears theshop/webpick too.2.4.0inshop/apiunticks SHOP-38, keeps2.4.0, and clearsshop/web.shop/apiunticks SHOP-38 only.shop/webstays on 1.9.0 because SHOP-36 still needs it.All three pass on main. I checked that they can fail by removing the
untickMissedcall frompick(): all three went red.Not covered: a hand pick in
shop/webthat differs from the issue's pick and survives. 1.9.0 is the only tag in that service's range, so testing it would need a new tag in the demo scenario, which would also change the README screenshot.