Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
15734d0 to
220c804
Compare
|
Thermo review finding — P2, blocking approval: Provider/account source routing for Kimi, Doubao, and OpenCode Go is duplicated between build_fetch_context in commands/providers.rs and project_token_account in rust/src/cli/usage/fetch_helpers.rs. Those independent matches can drift, causing the tray and CLI to route the same selected account differently. Please move the provider/account/source decision into one small shared policy helper in the Rust core, while leaving shell and CLI settings/account selection in their current owners. Cover Kimi cookie → Web, Doubao API key → OAuth, OpenCode Go Cookie + Auto → Web, and OpenCode Go API-key Auto/OAuth plus explicit Web/CLI rejection. |
Adversarial validation (lane-A) at 4663218Review verdict: no defects in A-620's own diff (e7b4e14..e0a4bdc, 18 files, +817/−98). The routing matches the 0.65.0 audit spec: Kimi selected accounts force the regional web route with isolated cookies and fail closed, Doubao Ark accounts use only the projected key, OpenCode Go distinguishes API-key and Cookie accounts, preserves saved source settings, and rejects explicit Web/CLI for an API-key account. Coverage in Merge defect found and fixed (the branch had to absorb the current #619 head
Checks at 4663218 (CARGO_TARGET_DIR=W:\cargo-target\lane-a, jobs=4, RUST_TEST_THREADS=4):
Fast-forward pushed |
…nt isolation folds into the Kimi auto seam and the #725 wallet rule)
|
Adversarial validation passed at 9240e34 Scope: provider-specific token account routing / account source pack (#620, upstream 0.65.0), validated as merged into release/v0.70.0 (merge 9240e34 = merge of 4663218 into f3375b8). Attacks (highest-risk semantics, from the merged tree):
No defects found. READY for the un-draft rule. |
Summary
Adds provider-specific token-account routing for Kimi, Doubao, and OpenCode Go using the existing shared account model.
This draft stacks on #619 (codex/port-0.65-provider-pack).
Validation
No frontend/UI files changed.