Skip to content

i18n(ja): fix function/argument name swaps - #23705

Merged
qiancai merged 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-reverse-function
Sep 3, 2026
Merged

i18n(ja): fix function/argument name swaps#23705
qiancai merged 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-reverse-function

Conversation

@yahonda

@yahonda yahonda commented Sep 2, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Follow-up to #23704 (which fixed cases where 機能 was wrongly used for a genuine function): this checks the reverse direction — cases where 関数 was used for something that is not actually a callable function.

Both confirmed defects turned out to be a function/argument role swap (not just a wrong word choice):

  • ai/integrations/vector-search-auto-embedding-{cohere,gemini,jina-ai,openai}.md (5 occurrences): EN says "the additional_json_options parameter of the EMBED_TEXT() function", but JA had the roles reversed (`additional_json_options`関数の`EMBED_TEXT()`パラメータ, making additional_json_options the function and EMBED_TEXT() the parameter).
  • releases/release-8.0.0.md: EN says "the json_path argument in the JSON_EXTRACT() function", but JA had `json_path`関数の`JSON_EXTRACT()`引数 (backwards).

123 total candidates matching the pattern (a lowercase backtick-quoted identifier immediately followed by 関数, without parentheses) were checked against the EN source; the other 121 were confirmed to be genuine SQL/Go function names correctly labeled 関数 and were left untouched.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Corrected Japanese documentation for Cohere, Gemini, Jina AI, and OpenAI embedding options, clarifying that additional_json_options is a parameter of EMBED_TEXT().
    • Clarified the Japanese TiDB 8.0.0 release notes to accurately describe the JSON_EXTRACT() function and its json_path argument.

@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 62a5c831-752c-4545-974c-a4be38360507

📥 Commits

Reviewing files that changed from the base of the PR and between 23d5ab9 and c2493dc.

📒 Files selected for processing (5)
  • ai/integrations/vector-search-auto-embedding-cohere.md
  • ai/integrations/vector-search-auto-embedding-gemini.md
  • ai/integrations/vector-search-auto-embedding-jina-ai.md
  • ai/integrations/vector-search-auto-embedding-openai.md
  • releases/release-8.0.0.md

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Documentation corrections

Layer / File(s) Summary
AI embedding option wording
ai/integrations/vector-search-auto-embedding-*.md
Corrects provider option descriptions to identify additional_json_options as a parameter of EMBED_TEXT().
Release note argument wording
releases/release-8.0.0.md
Clarifies that JSON_EXTRACT() accepts non-constant json_path argument values.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to c2493

This change corrects Japanese function and argument labels in five documentation files without changing product behavior. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: correcting swapped function and argument names in the Japanese documentation.
Description check ✅ Passed The description explains the changes, affected files, review scope, target Japanese TiDB 8.5 documentation branch, and AI involvement. The optional related-link fields are blank, but the required info…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the changes, affected files, review scope, target Japanese TiDB 8.5 documentation branch, and AI involvement. The optional related-link fields are blank, but the required information is sufficiently complete.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Sep 2, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jackysp for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 2, 2026
@yahonda yahonda changed the title i18n(ja): fix cases where 関数 was used for a non-function identifier i18n(ja): fix function/argument swaps mistranslated as feature terms Sep 2, 2026
@yahonda yahonda changed the title i18n(ja): fix function/argument swaps mistranslated as feature terms i18n(ja): fix function/argument name swaps Sep 2, 2026
@yahonda
yahonda marked this pull request as ready for review September 2, 2026 08:06
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
yahonda and others added 3 commits September 3, 2026 11:09
…part 1)

`additional_json_options` is a parameter of the `EMBED_TEXT()` function,
not a function itself. The Japanese translation had 関数/パラメータ
swapped between the two identifiers across 4 vector-search
auto-embedding guides (5 occurrences).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…part 2)

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@yahonda
yahonda force-pushed the fix-ja-reverse-function branch from c2493dc to c2d7fb6 Compare September 3, 2026 02:09
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 3, 2026
@qiancai
qiancai merged commit 0712fdf into pingcap:i18n-ja-release-8.5 Sep 3, 2026
2 of 8 checks passed
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 3, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-03 03:36:34.334969403 +0000 UTC m=+1336829.506063515: ☑️ agreed by qiancai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants