i18n(ja): fix function/argument name swaps - #23705
Conversation
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughChangesDocumentation corrections
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This change corrects Japanese function and argument labels in five documentation files without changing product behavior. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the changes, affected files, review scope, target Japanese TiDB 8.5 documentation branch, and AI involvement. The optional related-link fields are blank, but the required information is sufficiently complete. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…part 1) `additional_json_options` is a parameter of the `EMBED_TEXT()` function, not a function itself. The Japanese translation had 関数/パラメータ swapped between the two identifiers across 4 vector-search auto-embedding guides (5 occurrences). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…part 2) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
c2493dc to
c2d7fb6
Compare
[LGTM Timeline notifier]Timeline:
|
What is changed, added or deleted? (Required)
Follow-up to #23704 (which fixed cases where 機能 was wrongly used for a genuine function): this checks the reverse direction — cases where 関数 was used for something that is not actually a callable function.
Both confirmed defects turned out to be a function/argument role swap (not just a wrong word choice):
ai/integrations/vector-search-auto-embedding-{cohere,gemini,jina-ai,openai}.md(5 occurrences): EN says "theadditional_json_optionsparameter of theEMBED_TEXT()function", but JA had the roles reversed (`additional_json_options`関数の`EMBED_TEXT()`パラメータ, makingadditional_json_optionsthe function andEMBED_TEXT()the parameter).releases/release-8.0.0.md: EN says "thejson_pathargument in theJSON_EXTRACT()function", but JA had`json_path`関数の`JSON_EXTRACT()`引数(backwards).123 total candidates matching the pattern (a lowercase backtick-quoted identifier immediately followed by 関数, without parentheses) were checked against the EN source; the other 121 were confirmed to be genuine SQL/Go function names correctly labeled 関数 and were left untouched.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
additional_json_optionsis a parameter ofEMBED_TEXT().JSON_EXTRACT()function and itsjson_pathargument.