Skip to content

Logger Module For Efficient Transformers - #1282

Open
quic-vishali wants to merge 6 commits into
quic:mainfrom
quic-vishali:logger_support
Open

quic-vishali wants to merge 6 commits into
quic:mainfrom
quic-vishali:logger_support

Conversation

@quic-vishali

@quic-vishali quic-vishali commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds a structured logging module (QEFFLogger) to the QEfficient library,
based on quic/efficient-transformers#696.

  • QEFFLogger is a singleton logger with JSON formatter and rotating file handler.
  • Log level controlled project-wide via QEFF_LOG_LEVEL env var (default: INFO); log file path
    via QEFF_LOG_PATH or a timestamped default under ~/.cache/qefficient_logs/.
  • Namespace support per module (INFRA, MODEL, FT) for targeted filtering and post-processing.
  • All existing logging.getLogger(__name__) and module-level logger imports migrated to
    QEFFLogger.get_logger(namespace).
  • Jenkinsfile: all CI stages set QEFF_LOG_PATH=/efficient-transformers/Qeff_logs.
  • New unit tests in tests/utils/test_logger.py.
  • Generates process-aware filenames to avoid collisions between parallel workers:
    QEFF_YYYYMMDD_HHMMSS_PID.log.

Sample logs are available here - Qefficient_logs

@quic-vishali
quic-vishali marked this pull request as ready for review August 20, 2026 05:21
@quic-vishali
quic-vishali force-pushed the logger_support branch 2 times, most recently from 9189098 to 3f9feed Compare September 2, 2026 07:07
@quic-hemagnih

Copy link
Copy Markdown
Contributor

@quic-vishali Can you please resolve the conflicts and rebase the PR. Overall code changes looks okay to me. Please share a log file with the run for review.
Also take multiple runs to check the naming conventions for the log files.

@quic-hemagnih quic-hemagnih left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quic-vishali Can you please resolve the conflicts and rebase the PR. Overall code changes looks okay to me. Please share a log file with the run for review.
Also take multiple runs to check the naming conventions for the log files.

@quic-hemagnih

Copy link
Copy Markdown
Contributor

Comments from Qgenie looks relevant please check it once

@quic-vishali

Copy link
Copy Markdown
Contributor Author

@quic-hemagnih, Rebased the PR, and ran multiple tests with parallel workers to verify the naming convention.
I have attached the generated log files in the PR description.

@quic-hemagnih quic-hemagnih left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Vishali As dicussed offline can you please incorporate the following comments
Terminal messaging - Log file path and name for the run
Move the table inside the log file
API argument dump - from_pretrained, export, compile and generate
QPC path to be captured in logs

@quic-hemagnih quic-hemagnih left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quic-rishinr

Copy link
Copy Markdown
Contributor

CI-Ready

1 similar comment
@quic-rishinr

Copy link
Copy Markdown
Contributor

CI-Ready

Signed-off-by: Vishali Senthilkumar <vishsent@qti.qualcomm.com>
Signed-off-by: Vishali Senthilkumar <vishsent@qti.qualcomm.com>
Summary:
- Add structured argument logging for model APIs.
- Add secure argument serialization and secret redaction.
- Add shared process logs with run and model metadata.
- Add export, compile, and generation timing summaries.
- Move metrics table into the log file.
- Add Diffusers pipeline lifecycle logging.

Signed-off-by: Vishali Senthilkumar <vishsent@qti.qualcomm.com>
Signed-off-by: Vishali Senthilkumar <vishsent@qti.qualcomm.com>
Signed-off-by: Vishali Senthilkumar <vishsent@qti.qualcomm.com>
@quic-rishinr

Copy link
Copy Markdown
Contributor

CI-Ready

Signed-off-by: Vishali Senthilkumar <vishsent@qti.qualcomm.com>
@quic-hemagnih

Copy link
Copy Markdown
Contributor

CI-Ready

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants