Logger Module For Efficient Transformers - #1282
quic-vishali wants to merge 6 commits into
Conversation
9189098 to
3f9feed
Compare
|
@quic-vishali Can you please resolve the conflicts and rebase the PR. Overall code changes looks okay to me. Please share a log file with the run for review. |
quic-hemagnih
left a comment
There was a problem hiding this comment.
@quic-vishali Can you please resolve the conflicts and rebase the PR. Overall code changes looks okay to me. Please share a log file with the run for review.
Also take multiple runs to check the naming conventions for the log files.
|
Comments from Qgenie looks relevant please check it once |
e0624f4 to
601bd5d
Compare
|
@quic-hemagnih, Rebased the PR, and ran multiple tests with parallel workers to verify the naming convention. |
quic-hemagnih
left a comment
There was a problem hiding this comment.
Hi Vishali As dicussed offline can you please incorporate the following comments
Terminal messaging - Log file path and name for the run
Move the table inside the log file
API argument dump - from_pretrained, export, compile and generate
QPC path to be captured in logs
80b1deb to
cc165d0
Compare
cc165d0 to
c8a9ff4
Compare
|
CI-Ready |
1 similar comment
|
CI-Ready |
bf7f044 to
5daae7e
Compare
Signed-off-by: Vishali Senthilkumar <vishsent@qti.qualcomm.com>
Signed-off-by: Vishali Senthilkumar <vishsent@qti.qualcomm.com>
Summary: - Add structured argument logging for model APIs. - Add secure argument serialization and secret redaction. - Add shared process logs with run and model metadata. - Add export, compile, and generation timing summaries. - Move metrics table into the log file. - Add Diffusers pipeline lifecycle logging. Signed-off-by: Vishali Senthilkumar <vishsent@qti.qualcomm.com>
Signed-off-by: Vishali Senthilkumar <vishsent@qti.qualcomm.com>
Signed-off-by: Vishali Senthilkumar <vishsent@qti.qualcomm.com>
5daae7e to
6adb78a
Compare
6adb78a to
45c7e42
Compare
|
CI-Ready |
45c7e42 to
b0b42d8
Compare
Signed-off-by: Vishali Senthilkumar <vishsent@qti.qualcomm.com>
b0b42d8 to
a23c45a
Compare
|
CI-Ready |
Summary
Adds a structured logging module (
QEFFLogger) to the QEfficient library,based on quic/efficient-transformers#696.
QEFFLoggeris a singleton logger with JSON formatter and rotating file handler.QEFF_LOG_LEVELenv var (default: INFO); log file pathvia
QEFF_LOG_PATHor a timestamped default under~/.cache/qefficient_logs/.INFRA,MODEL,FT) for targeted filtering and post-processing.logging.getLogger(__name__)and module-levelloggerimports migrated toQEFFLogger.get_logger(namespace).QEFF_LOG_PATH=/efficient-transformers/Qeff_logs.tests/utils/test_logger.py.QEFF_YYYYMMDD_HHMMSS_PID.log.Sample logs are available here - Qefficient_logs