Skip to content

Logger Module For Efficient Transformers - #696

Closed
abhishek-singh591 wants to merge 27 commits into
quic:mainfrom
abhishek-singh591:logger_support
Closed

abhishek-singh591 wants to merge 27 commits into
quic:mainfrom
abhishek-singh591:logger_support

Conversation

@abhishek-singh591

Copy link
Copy Markdown
Contributor

This PR is to add support for Logger Module in Efficient Transformer library. QEFFLogger will run in a low priority thread and shall have a thread safe queue waiting for logs coming from different modules running in single or multi threaded enviornment. This shall support capturing logs classified at various log levels and user can set different log levels for different namespace so that user can have control of logging and thereby easing the debugging. These logs are dumped in the JSON format so that post processing can be done easily.

Signed-off-by: abhishek-singh591 <sabhis@qti.qualcomm.com>
Signed-off-by: abhishek-singh591 <sabhis@qti.qualcomm.com>
Signed-off-by: abhishek-singh591 <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: abhishek-singh591 <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Comment thread QEfficient/base/modeling_qeff.py Outdated
Comment thread QEfficient/generation/text_generation_inference.py Outdated
Comment thread QEfficient/utils/logging_utils.py Outdated
Comment thread QEfficient/utils/logging_utils.py Outdated
Comment thread QEfficient/utils/logging_utils.py Outdated
Comment thread QEfficient/utils/logging_utils.py
Comment thread pyproject.toml Outdated
Comment thread QEfficient/base/modeling_qeff.py Outdated
Comment thread QEfficient/utils/logging_utils.py
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>

@quic-hemagnih quic-hemagnih left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please rebase it and also add this logger to all the FT files too, its inconsistent for FT.

Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: abhishek-singh591 <sabhis@qti.qualcomm.com>
Signed-off-by: abhishek-singh591 <sabhis@qti.qualcomm.com>
@quic-rishinr

Copy link
Copy Markdown
Contributor

Can we include the export and compile time in the logs?

@quic-rishinr

Copy link
Copy Markdown
Contributor

@abhishek-singh591 @quic-hemagnih is there anything pending on this PR apart from export and compile time? Can we get it merged ASAP?

@abhishek-singh591

Copy link
Copy Markdown
Contributor Author

@abhishek-singh591 @quic-hemagnih is there anything pending on this PR apart from export and compile time? Can we get it merged ASAP?

Export and compile time are already being reported in the table. I haven’t added Qeff logging for the FT files yet @quic-hemagnih should I include support for finetuning as part of this PR?

@quic-rishinr

Copy link
Copy Markdown
Contributor

Lets take it as a separate PR. lets get the PR merged. Please rebase the PR
@quic-hemagnih could you please review and merge the PR

@quic-rishinr

Copy link
Copy Markdown
Contributor

@quic-hemagnih @abhishek-singh591 any update on this PR? lets close the PR and migrate the changes to a new PR on top of mainline. Lets close this in next couple of weeks as its pending for a long time.

@ochougul
ochougul marked this pull request as draft August 4, 2026 16:40
@quic-hemagnih

Copy link
Copy Markdown
Contributor

@abhishek-singh591 we can close this PR as its been taken up by the PR #1282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants