Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid clearing/copying the 64 KiB XGKICK packet buffer at every transfer launch. Reset only the transfer metadata in
startXgkick; keep reset/initialization behavior unchanged.progressXgkickwrites each transferred qword before publishing the copied prefix, and a packet is submitted only after its complete declared length has been copied. Bytes beyond that prefix do not need initialization between transfers. The existing source-address, issue-cycle, and cycle-credit assignments remain unchanged.With MSVC Release in the integration build, the old aggregate assignment produced a 64 KiB stack temporary, memset, and memcpy. Binary inspection confirms those bulk operations and the large stack frame disappear with this change.
Regression Coverage
A synthetic microprogram issues consecutive 4096-, 32-, and 80-byte IMAGE packets through the same storage. The test compares every submitted byte and exact packet lengths, checks completion cycles 511/514/523, and repeats with 4096/1/3/8/64-cycle execution budgets. No private game assets or generated game code are included.
Validation
14b1e5c.No packet timing, rendering semantics, public API, or structure-layout change is intended.