Avoid global declarations in generated function bodies - #253
Open
jfmherokiller wants to merge 1 commit into
Open
jfmherokiller wants to merge 1 commit into
jfmherokiller wants to merge 1 commit into
Conversation
jfmherokiller
force-pushed
the
codex/remove-generated-header-dependency
branch
from
September 6, 2026 23:49
6bf3a00 to
f5f8cfa
Compare
jfmherokiller
force-pushed
the
codex/remove-generated-header-dependency
branch
from
September 7, 2026 02:03
f5f8cfa to
403305a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated function bodies dispatch guest calls through PS2Runtime and do not reference declarations for every generated function. Removing the unused header prevents a function-map rename from invalidating every generated translation unit; only the changed body and registration table need recompilation.
Validation: built
ps2_recompwith GCC 16 from a clean native build. Added an emitter regression test that keeps the header out of per-function output.