Use module umbrella headers in attributedstring (#58814) - #58814
Open
j-piasecki wants to merge 1 commit into
Open
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123001117. |
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
Summary: Pull Request resolved: react#58814 The `attributedstring` headers included fine-grained headers from other modules that are protected by `UmbrellaGuard.h`, which hard-errors for consumers building with `RN_STRICT_API`. Include the module umbrella headers instead. Changelog: [Internal] Differential Revision: D123001117
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D123001117
branch
from
October 2, 2026 12:21
880cd59 to
a5b80df
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
attributedstringheaders included fine-grained headers from other modules that are protected byUmbrellaGuard.h, which hard-errors for consumers building withRN_STRICT_API. Include the module umbrella headers instead.Changelog: [Internal]
Differential Revision: D123001117