Fix in-tree builds by namespacing the emitFromONNX target - #312
Merged
Conversation
When rootbench is built as part of ROOT itself, the emitFromONNX
executable target clashed with the target of the same name defined by
the SOFIE tests in tmva/sofie/test, aborting the CMake configuration:
CMake Error at rootbench/root/tmva/sofie/CMakeLists.txt:67 (add_executable):
add_executable cannot create target "emitFromONNX" because another
target with the same name already exists.
Rename the rootbench target to rootbench-emitFromONNX to keep the two
builds out of each other's way. The tool is an internal build step, so
nothing user-facing changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rootbench is built as part of ROOT itself, the emitFromONNX executable target clashed with the target of the same name defined by the SOFIE tests in tmva/sofie/test, aborting the CMake configuration:
CMake Error at rootbench/root/tmva/sofie/CMakeLists.txt:67 (add_executable):
add_executable cannot create target "emitFromONNX" because another
target with the same name already exists.
Rename the rootbench target to rootbench-emitFromONNX to keep the two builds out of each other's way. The tool is an internal build step, so nothing user-facing changes.