Skip to content

Fix in-tree builds by namespacing the emitFromONNX target #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guitargeek merged 1 commit into from
Sep 5, 2026
Merged

Fix in-tree builds by namespacing the emitFromONNX target #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions root/tmva/sofie/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,13 @@ set(sofie_models
SimpleNN_Alice
higgs_model_dense)

# Command line tool that generates the inference code for an ONNX model.
add_executable(emitFromONNX EmitFromONNX.cxx)
target_link_libraries(emitFromONNX Core ROOTTMVASofie ROOTTMVASofieParser)
set_target_properties(emitFromONNX PROPERTIES POSITION_INDEPENDENT_CODE TRUE)
# Command line tool that generates the inference code for an ONNX model. The
# target name is prefixed with "rootbench-" to avoid a clash with the
# emitFromONNX target of the SOFIE tests when rootbench is built as part of
# ROOT itself.
add_executable(rootbench-emitFromONNX EmitFromONNX.cxx)
target_link_libraries(rootbench-emitFromONNX Core ROOTTMVASofie ROOTTMVASofieParser)
set_target_properties(rootbench-emitFromONNX PROPERTIES POSITION_INDEPENDENT_CODE TRUE)

set(model_dir ${CMAKE_CURRENT_BINARY_DIR}/input_models)
set(model_generator ${CMAKE_CURRENT_SOURCE_DIR}/make_input_models.py)
Expand All @@ -80,8 +83,8 @@ foreach(name ${sofie_models})
COMMENT "Generating ONNX model ${name}")
add_custom_command(
OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${name}.hxx ${CMAKE_CURRENT_BINARY_DIR}/${name}.dat
COMMAND emitFromONNX ${model_dir}/${name}.onnx
DEPENDS emitFromONNX ${model_dir}/${name}.onnx
COMMAND rootbench-emitFromONNX ${model_dir}/${name}.onnx
DEPENDS rootbench-emitFromONNX ${model_dir}/${name}.onnx
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
COMMENT "Generating SOFIE inference code for ${name}")
list(APPEND sofie_headers ${CMAKE_CURRENT_BINARY_DIR}/${name}.hxx)
Expand Down
Loading