Skip to content

added unix time function and wget - #72

Closed
nkulkarni wants to merge 2 commits into
rootvc:mainfrom
nkulkarni:nk-add-time-function
Closed

added unix time function and wget#72
nkulkarni wants to merge 2 commits into
rootvc:mainfrom
nkulkarni:nk-add-time-function

Conversation

@nkulkarni

Copy link
Copy Markdown
Contributor

Added a quick little unix time function. Might need to change the formatting a bit, but ...
Also added wget, because it's been a while since I have written any JS

guest:rootpc ~ $ date
Wed Feb 22 2023 22:11:37 GMT-0800 (Pacific Standard Time)
guest:rootpc ~ $ wget
wget: missing URL
guest:rootpc ~ $ wget google.com
wget not installed. try: curl google.com

ledwards added a commit that referenced this pull request Aug 13, 2026
* Land three stalled command contributions, and finish the RickRoll move

Four PRs sat open for between one and four years. The ideas were good; the
patches had rotted against a file that moved underneath them. Reapplied here
with credit.

- cowsay (#106) — prints the classic bubble and cow. Uses writeln rather than
  stylePrint because it is alignment-sensitive art that stylePrint would wrap
  and recolor.
- date and wget (#72) — date prints the real thing; wget points at curl, which
  already has the joke response.
- The RickRoll (#84, #85). Both PRs wanted the joke to play in the terminal
  instead of punting the user to an imgur GIF in a new tab. That landed for
  `test` at some point, but `cat id_rsa`, `grep <pattern> id_rsa` and
  `open test.htm` were left behind still opening the GIF. All four now go
  through one _rickRoll() helper, so they cannot drift apart again.

Verified in a browser against a built dist/: cowsay renders correctly, date and
wget print as expected, and all four RickRoll routes fire the in-terminal
animation with zero external URLs opened.

Co-Authored-By: mantra-1 <mantra-1@users.noreply.github.com>
Co-Authored-By: nkulkarni <nkulkarni@users.noreply.github.com>
Co-Authored-By: ophiuchus44 <ophiuchus44@users.noreply.github.com>
Co-Authored-By: jandobrx <jandobrx@users.noreply.github.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Add cd test coverage, ported from #51

cd is the one command with real branching — a switch over ~, .., /home, /bin
and team member names, several branches of which recurse through term.command
— and it drives term.cwd, which the prompt renders on every keystroke. It had
no tests.

The table comes from #51 (@astonm, November 2021), which never landed. Its
harness is long gone, but every case it asserted still describes the intended
behaviour, so the table is ported onto the current vitest setup and extended
with the permission-denied and unknown-directory paths.

Co-Authored-By: astonm <astonm@users.noreply.github.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: mantra-1 <mantra-1@users.noreply.github.com>
Co-authored-by: nkulkarni <nkulkarni@users.noreply.github.com>
Co-authored-by: ophiuchus44 <ophiuchus44@users.noreply.github.com>
Co-authored-by: jandobrx <jandobrx@users.noreply.github.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: astonm <astonm@users.noreply.github.com>
@ledwards

Copy link
Copy Markdown
Contributor

Landed in #134, with credit to you in the commit — both date and wget, plus entries in the README's advanced command list. wget keeps your no-URL guard and points at curl, which already carries the joke response.

The patch itself no longer applied (config/commands.js has moved a long way since 2023), so it was reapplied rather than merged. Verified both in a real terminal.

@ledwards ledwards closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants