Skip to content

Land five stalled contributions from the PR backlog - #134

Merged
ledwards merged 2 commits into
mainfrom
pr-queue-cleanup
Aug 13, 2026
Merged

Land five stalled contributions from the PR backlog#134
ledwards merged 2 commits into
mainfrom
pr-queue-cleanup

Conversation

@ledwards

Copy link
Copy Markdown
Contributor

Five PRs, open between one and four years, whose ideas were good but whose patches no longer applied. Reapplied on current main with credit to the original authors.

Original Author What landed
#106 @mantra-1 cowsay
#72 @nkulkarni date and wget
#84 / #85 @ophiuchus44, @jandobrx RickRoll plays in-terminal everywhere
#51 @astonm cd test coverage

Commands

cowsay prints the classic bubble and cow. It uses writeln rather than stylePrint because it's alignment-sensitive art that stylePrint would wrap and recolor.

date prints the real date. wget points at curl, which already carries the joke response.

All three are added to the README's advanced command list. Tab completion picks them up from the commands object automatically.

The RickRoll

#84 and #85 both wanted the joke to play in the terminal instead of punting the user to an imgur GIF in a new tab. That landed for test at some point — but cat id_rsa, grep <pattern> id_rsa and open test.htm were left behind, still calling openURL on the GIF.

So the original complaint was still half-true. All four routes now go through a single _rickRoll() helper, which means they can't drift apart again. Their proposed fix (shelling out to ascii.live/rick via curl) isn't used — the repo's own rickroll.js animation is better and has no external dependency.

cd tests

cd is the one command with real branching — a switch over ~, .., /home, /bin and team member names, several branches of which recurse through term.command — and it drives term.cwd, which the prompt renders on every keystroke. It had no tests.

The table is @astonm's from #51, ported to the current vitest harness and extended with the permission-denied and unknown-directory paths.

Test plan

  • npm test — all passing, 20 new cases
  • npm run build, served dist/, and exercised each command in a real terminal: cowsay renders correctly, date and wget print as expected (both with and without an argument)
  • Confirmed all four RickRoll routes fire the in-terminal animation and open zero external URLs

Closes #106, #72, #84, #85, #51.

🤖 Generated with Claude Code

ledwards and others added 2 commits August 12, 2026 18:52
Four PRs sat open for between one and four years. The ideas were good; the
patches had rotted against a file that moved underneath them. Reapplied here
with credit.

- cowsay (#106) — prints the classic bubble and cow. Uses writeln rather than
  stylePrint because it is alignment-sensitive art that stylePrint would wrap
  and recolor.
- date and wget (#72) — date prints the real thing; wget points at curl, which
  already has the joke response.
- The RickRoll (#84, #85). Both PRs wanted the joke to play in the terminal
  instead of punting the user to an imgur GIF in a new tab. That landed for
  `test` at some point, but `cat id_rsa`, `grep <pattern> id_rsa` and
  `open test.htm` were left behind still opening the GIF. All four now go
  through one _rickRoll() helper, so they cannot drift apart again.

Verified in a browser against a built dist/: cowsay renders correctly, date and
wget print as expected, and all four RickRoll routes fire the in-terminal
animation with zero external URLs opened.

Co-Authored-By: mantra-1 <mantra-1@users.noreply.github.com>
Co-Authored-By: nkulkarni <nkulkarni@users.noreply.github.com>
Co-Authored-By: ophiuchus44 <ophiuchus44@users.noreply.github.com>
Co-Authored-By: jandobrx <jandobrx@users.noreply.github.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
cd is the one command with real branching — a switch over ~, .., /home, /bin
and team member names, several branches of which recurse through term.command
— and it drives term.cwd, which the prompt renders on every keystroke. It had
no tests.

The table comes from #51 (@astonm, November 2021), which never landed. Its
harness is long gone, but every case it asserted still describes the intended
behaviour, so the table is ported onto the current vitest setup and extended
with the permission-denied and unknown-directory paths.

Co-Authored-By: astonm <astonm@users.noreply.github.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@ledwards
ledwards merged commit 384d00c into main Aug 13, 2026
6 checks passed
@ledwards
ledwards deleted the pr-queue-cleanup branch August 13, 2026 01:53
ledwards added a commit that referenced this pull request Aug 13, 2026
#134 dropped `swag` from config/commands.js while help.js and the README kept
advertising it, so `help` listed a command that did nothing. My fault: I had
edits to commands.js spread across two working trees and consolidated them by
copying one file over the other, which silently reverted the two changes #132
had made to it — the command itself and a stale comment above `www`.

Both are restored. The new test is the more useful half: nothing linked
config/help.js to config/commands.js, so help could advertise a command that
did not exist and no test would notice. It now walks every %command% in help.js
and asserts a matching function exists.

Verified the test fails with the exact diagnostic (expected [ 'swag' ] to
deeply equal []) when the command is removed again.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant