Land five stalled contributions from the PR backlog - #134
Merged
Conversation
Four PRs sat open for between one and four years. The ideas were good; the patches had rotted against a file that moved underneath them. Reapplied here with credit. - cowsay (#106) — prints the classic bubble and cow. Uses writeln rather than stylePrint because it is alignment-sensitive art that stylePrint would wrap and recolor. - date and wget (#72) — date prints the real thing; wget points at curl, which already has the joke response. - The RickRoll (#84, #85). Both PRs wanted the joke to play in the terminal instead of punting the user to an imgur GIF in a new tab. That landed for `test` at some point, but `cat id_rsa`, `grep <pattern> id_rsa` and `open test.htm` were left behind still opening the GIF. All four now go through one _rickRoll() helper, so they cannot drift apart again. Verified in a browser against a built dist/: cowsay renders correctly, date and wget print as expected, and all four RickRoll routes fire the in-terminal animation with zero external URLs opened. Co-Authored-By: mantra-1 <mantra-1@users.noreply.github.com> Co-Authored-By: nkulkarni <nkulkarni@users.noreply.github.com> Co-Authored-By: ophiuchus44 <ophiuchus44@users.noreply.github.com> Co-Authored-By: jandobrx <jandobrx@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
cd is the one command with real branching — a switch over ~, .., /home, /bin and team member names, several branches of which recurse through term.command — and it drives term.cwd, which the prompt renders on every keystroke. It had no tests. The table comes from #51 (@astonm, November 2021), which never landed. Its harness is long gone, but every case it asserted still describes the intended behaviour, so the table is ported onto the current vitest setup and extended with the permission-denied and unknown-directory paths. Co-Authored-By: astonm <astonm@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 13, 2026
ledwards
added a commit
that referenced
this pull request
Aug 13, 2026
#134 dropped `swag` from config/commands.js while help.js and the README kept advertising it, so `help` listed a command that did nothing. My fault: I had edits to commands.js spread across two working trees and consolidated them by copying one file over the other, which silently reverted the two changes #132 had made to it — the command itself and a stale comment above `www`. Both are restored. The new test is the more useful half: nothing linked config/help.js to config/commands.js, so help could advertise a command that did not exist and no test would notice. It now walks every %command% in help.js and asserts a matching function exists. Verified the test fails with the exact diagnostic (expected [ 'swag' ] to deeply equal []) when the command is removed again. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five PRs, open between one and four years, whose ideas were good but whose patches no longer applied. Reapplied on current
mainwith credit to the original authors.cowsaydateandwgetcdtest coverageCommands
cowsayprints the classic bubble and cow. It useswritelnrather thanstylePrintbecause it's alignment-sensitive art thatstylePrintwould wrap and recolor.dateprints the real date.wgetpoints atcurl, which already carries the joke response.All three are added to the README's advanced command list. Tab completion picks them up from the
commandsobject automatically.The RickRoll
#84 and #85 both wanted the joke to play in the terminal instead of punting the user to an imgur GIF in a new tab. That landed for
testat some point — butcat id_rsa,grep <pattern> id_rsaandopen test.htmwere left behind, still callingopenURLon the GIF.So the original complaint was still half-true. All four routes now go through a single
_rickRoll()helper, which means they can't drift apart again. Their proposed fix (shelling out toascii.live/rickvia curl) isn't used — the repo's ownrickroll.jsanimation is better and has no external dependency.cd tests
cdis the one command with real branching — a switch over~,..,/home,/binand team member names, several branches of which recurse throughterm.command— and it drivesterm.cwd, which the prompt renders on every keystroke. It had no tests.The table is @astonm's from #51, ported to the current vitest harness and extended with the permission-denied and unknown-directory paths.
Test plan
npm test— all passing, 20 new casesnpm run build, serveddist/, and exercised each command in a real terminal: cowsay renders correctly,dateandwgetprint as expected (both with and without an argument)Closes #106, #72, #84, #85, #51.
🤖 Generated with Claude Code