Fixed cors ascii rick roll instead of opening gif in new window - #85
Fixed cors ascii rick roll instead of opening gif in new window#85jandobrx wants to merge 8 commits into
Conversation
|
omg amazing This has been on my feature list for over a year and never really gotten around to it. Thank you!! Your test deployment shows it working on desktop for me (Chrome and Safari for Mac) but not getting it to work on mobile (mobile Safari) - it shows Nice try but then a bunch of blank lines. Given we're a VC website, iOS is actually our #1 platform haha - this is so close, I'll try to dig into debugging it on mobile Safari and then I 100% want to merge. Thank you!! |
This commit switches from injecting a video, to using a 54 frame ASCII Rick Roll. Note that Mobile and Desktop versions contain two different AA Arrays due to resolution constrains.
|
We were super excited to hear that! @gurgenbrx pushed another version last night with a fix to the mobile/Safari! Also seems to be a strange bug I was able to load it on my iphone/safari, I believe it was an issue with netlify serving video as a CDN! The new patch should fix all the views for mobile! We also used the 40 line convention to switch a view for the main ASCII animation from desktop to mobile! Fortunately when dealing in the tokenization world we've become experts with characters and ascii manipulation :) There's also a quick AA tutorial if you want to turn any other video/image into this format! e25150d |
* Land three stalled command contributions, and finish the RickRoll move Four PRs sat open for between one and four years. The ideas were good; the patches had rotted against a file that moved underneath them. Reapplied here with credit. - cowsay (#106) — prints the classic bubble and cow. Uses writeln rather than stylePrint because it is alignment-sensitive art that stylePrint would wrap and recolor. - date and wget (#72) — date prints the real thing; wget points at curl, which already has the joke response. - The RickRoll (#84, #85). Both PRs wanted the joke to play in the terminal instead of punting the user to an imgur GIF in a new tab. That landed for `test` at some point, but `cat id_rsa`, `grep <pattern> id_rsa` and `open test.htm` were left behind still opening the GIF. All four now go through one _rickRoll() helper, so they cannot drift apart again. Verified in a browser against a built dist/: cowsay renders correctly, date and wget print as expected, and all four RickRoll routes fire the in-terminal animation with zero external URLs opened. Co-Authored-By: mantra-1 <mantra-1@users.noreply.github.com> Co-Authored-By: nkulkarni <nkulkarni@users.noreply.github.com> Co-Authored-By: ophiuchus44 <ophiuchus44@users.noreply.github.com> Co-Authored-By: jandobrx <jandobrx@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Add cd test coverage, ported from #51 cd is the one command with real branching — a switch over ~, .., /home, /bin and team member names, several branches of which recurse through term.command — and it drives term.cwd, which the prompt renders on every keystroke. It had no tests. The table comes from #51 (@astonm, November 2021), which never landed. Its harness is long gone, but every case it asserted still describes the intended behaviour, so the table is ported onto the current vitest setup and extended with the permission-denied and unknown-directory paths. Co-Authored-By: astonm <astonm@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: mantra-1 <mantra-1@users.noreply.github.com> Co-authored-by: nkulkarni <nkulkarni@users.noreply.github.com> Co-authored-by: ophiuchus44 <ophiuchus44@users.noreply.github.com> Co-authored-by: jandobrx <jandobrx@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: astonm <astonm@users.noreply.github.com>
|
Landed in #134, with credit to you in the commit. Your read was right and still half-true when I got to it: the in-terminal RickRoll existed for The one thing that didn't carry over is the mechanism — rather than shelling out to |
3 participants
We saw that a recent PR featured a rick roll curl, thought it was a great addition but had a CORS issue. Wanted to fix it!
Updated Xterm to the new version, fixed cursor position bug after setCurrentLine(), added a video that appends in the DOM.
Test Netlify Deployment w/changes:
https://main--test-cli-rick.netlify.app/