fix: update Core and updater atomically#593
Closed
frahlg wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Superseded by #628, rebuilt from current master. #593 is 50+ master commits behind and has content conflicts in the updater. Master already preserves per-component rollback image IDs and checks Core readiness; the old branch also bypassed the newer healthy-Optimizer preflight. #628 keeps those master fixes and carries only the current Core/updater pair contract, tests, changeset, release gate, migration rollback, and operator notes. No commit from #593 will be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Core and updater were published and replaced independently. A legacy updater could accept a new update request while replacing Core only, and the boot health endpoint reported success while state initialization or migration was still running. That allowed a mixed control plane or a false-success commit boundary.
Impact
Core now verifies updater protocol and exact release identity before opening state. Paired updates commit only when both services run the requested immutable tag and Core is fully ready; any failure restores updater first and then Core from their retained image IDs. Optimizer, drivers, authentication, persistent data ownership, and the control loop remain outside this change.
Validation
make verifymake verify-allincluding linux/arm64, linux/amd64, and windows/amd64 cross-compilesnpm test(48 tests)Rollout gate