fix: update Core and updater as one release pair#628
Draft
frahlg wants to merge 4 commits into
Draft
Conversation
frahlg
force-pushed
the
codex/atomic-control-plane-pair-v2
branch
from
July 22, 2026 06:34
4db8548 to
a9b37be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#593 used an old release layout and conflicted with master. Master already keeps per-component rollback image IDs, checks Core
/api/statusbefore it accepts an update, and blocks Core updates when Optimizer is not healthy. This PR keeps those rules and adds the missing Core/updater pair contract.What changes
/statusprotocol 2 or later, capabilitycontrol-plane-pair-v1, andupdater_versionequal to the running Core version before Core opens state.ftw-control-plane.jsonto name the same Core/updater release and pin both images by digest.repo@sha256:...refs and inspect both running refs beforedone.doneorfailedstate.doneorfailedresult, including when stop returns an error.failed, neverdone./api/status;/api/healthremains boot liveness only.Compatibility
state.Open; no migrationstate.Open; no migrationfailedOptimizer stays on
name=ftw-optimizer, exact protocol 1, plan schema 1, and feature checks. It is not part offtw-control-plane.json.Checks
go test ./cmd/ftw-updater ./internal/selfupdate ./internal/api ./cmd/ftw -count=1— passbash scripts/test-modular-compose.sh— passgo test -race ./cmd/ftw-updater ./internal/selfupdate -count=1— pass-race -count=20— passmake verify— pass on3e765dd2make verify— passmake verify-all— passmake verify-all— pass, including Linux arm64/amd64 and Windows amd64 builds3e765dd2— pendingThe focused tests cover:
restoringowned by a normal helper and by a recovery helper;doneandfailedwrites racing a heartbeat read/update;doneduring successful helper stop and terminalfailedduring a stop error;failed, and both old image IDs retained;Rollout gate
Keep this PR draft. Do not merge or publish a Core beta from this head yet.
Completed prerequisites:
e9adb3113513dcd449268096b0dd637f4753ed24. It did not test this PR.Still required:
3e765dd24ddafe512372389b1803f464f876ee65.ftw-control-plane.jsonuses the same source revision./api/statusstays false until state and migrations are ready;failed;Supersedes #593. This PR does not change driver source, auth, persistent data ownership, Optimizer release logic, or the control loop. It does not use #623 as its integration path.