fix: 家事詳細画面をスクロール可能にし小さい画面での見切れを解消 - #326
stotic-dev wants to merge 6 commits into
Conversation
Closes #320 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
doc/adr/0005: Xcode Cloud上で記録した参照PNGの自動commitです。 PRコメントのDangerによるbefore/after画像差分でレビューしてください。
Generated by 🚫 Danger Swift against 82532b2 |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6a98cc02e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ScrollView { | ||
| VStack(spacing: .space40) { |
There was a problem hiding this comment.
When VRT runs, this layout renders the action button directly below the item list instead of at the bottom, but all four existing HouseworkDetailView_0-* baselines under hometeSnapshotTests/__Snapshots__/PreviewTests.generated remain byte-identical to the parent commit. The snapshot test will therefore compare the new render against the old layout and fail for both tested devices and color schemes; regenerate and commit those full-screen detail baselines after this change.
Useful? React with 👍 / 👎.
…scroll # Conflicts: # LocalPackage/Sources/Features/HouseworkFeature/HouseworkDetailView/HouseworkDetailView.swift
doc/adr/0005: Xcode Cloud上で記録した参照PNGの自動commitです。 PRコメントのDangerによるbefore/after画像差分でレビューしてください。
snapshotの変更更新ファイル:
|
| before | after |
|---|---|
 |
 |
更新ファイル: HouseworkDetailView_0-iPhone-16.1.png
| before | after |
|---|---|
 |
 |
更新ファイル: HouseworkDetailView_0-iPhone-SE-2nd-generation-dark.1.png
| before | after |
|---|---|
 |
 |
更新ファイル: HouseworkDetailView_0-iPhone-SE-2nd-generation.1.png
| before | after |
|---|---|
 |
 |
Generated by 🚫 Danger Swift against 82532b2
This branch has not been deployed
2 participants
経緯
家事詳細画面にコンテンツが多いと、小さい画面（iPhone SEなど）で表示が見切れていたため修正する。
Closes #320
実装内容
HouseworkDetailItemListContent）とアクションボタン（HouseworkDetailActionContent）をまとめてScrollViewで包み、画面に収まらない場合はスクロールできるようにしたScrollViewの中ではSpacerが伸びないため、アクションボタンは画面下部ではなく項目一覧の直下（.space40の間隔）に配置される。高さを取るためのGeometryReaderを避け、構造を単純に保つためこのレイアウトとした.scrollBounceBehavior(.basedOnSize)で収まる場合はバウンスさせず、.softTopScrollEdgeEffect()と合わせて同じ機能内のHouseworkThanksViewと挙動を揃えた確認内容
swift buildが通ることmake test-packagesのユニットテストが全て通ること🤖 Generated with Claude Code