Skip to content
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ public struct HouseworkDetailView: View {

public var body: some View {
mainContent()
.padding(.horizontal, .space16)
.padding(.bottom, .space24)
.fullScreenLoadingIndicator(loadingState)
.navigationTitle(item.title)
.inlineNavigationBarTitleDisplayMode()
Expand All @@ -51,20 +49,25 @@ public struct HouseworkDetailView: View {
private extension HouseworkDetailView {

func mainContent() -> some View {
VStack(spacing: .zero) {
HouseworkDetailItemListContent(
cohabitantMemberList: cohabitantStore.members,
item: item,
thanksMessages: HouseworkThanksMessage.make(item: item, memberList: cohabitantStore.members)
)
Spacer()
HouseworkDetailActionContent(
isLoading: $loadingState.isLoading,
commonErrorContent: $commonErrorContent,
account: account,
item: item
)
ScrollView {
VStack(spacing: .space40) {
Comment on lines +52 to +53

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the full-screen detail snapshots

When VRT runs, this layout renders the action button directly below the item list instead of at the bottom, but all four existing HouseworkDetailView_0-* baselines under hometeSnapshotTests/__Snapshots__/PreviewTests.generated remain byte-identical to the parent commit. The snapshot test will therefore compare the new render against the old layout and fail for both tested devices and color schemes; regenerate and commit those full-screen detail baselines after this change.

Useful? React with 👍 / 👎.

HouseworkDetailItemListContent(
cohabitantMemberList: cohabitantStore.members,
item: item,
thanksMessages: HouseworkThanksMessage.make(item: item, memberList: cohabitantStore.members)
)
HouseworkDetailActionContent(
isLoading: $loadingState.isLoading,
commonErrorContent: $commonErrorContent,
account: account,
item: item
)
}
.padding(.horizontal, .space16)
.padding(.bottom, .space24)
}
.scrollBounceBehavior(.basedOnSize)
.softTopScrollEdgeEffect()
}

}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading