-
Notifications
You must be signed in to change notification settings - Fork 0
fix: 家事詳細画面をスクロール可能にし小さい画面での見切れを解消 #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stotic-dev
wants to merge
6
commits into
main
Choose a base branch
from
fix/housework-detail-scroll
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
22157d2
fix: 家事詳細画面をスクロール可能にし小さい画面での見切れを解消
stotic-dev 51b0760
fix: 家事詳細画面のアクションボタンをsafeAreaInsetで下部固定しGeometryReaderを削除
stotic-dev 57327c9
chore: VRT参照スナップショットを自動更新
stotic-dev a6a98cc
fix: 家事詳細画面のアクションボタンもScrollView内に含める
stotic-dev b9c3774
Merge remote-tracking branch 'origin/main' into fix/housework-detail-…
stotic-dev 82532b2
chore: VRT参照スナップショットを自動更新
stotic-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+946 Bytes
(100%)
...__Snapshots__/PreviewTests.generated/HouseworkDetailView_0-iPhone-16-dark.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+40 Bytes
(100%)
...ests/__Snapshots__/PreviewTests.generated/HouseworkDetailView_0-iPhone-16.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+174 Bytes
(100%)
...reviewTests.generated/HouseworkDetailView_0-iPhone-SE-2nd-generation-dark.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+284 Bytes
(100%)
...s__/PreviewTests.generated/HouseworkDetailView_0-iPhone-SE-2nd-generation.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When VRT runs, this layout renders the action button directly below the item list instead of at the bottom, but all four existing
HouseworkDetailView_0-*baselines underhometeSnapshotTests/__Snapshots__/PreviewTests.generatedremain byte-identical to the parent commit. The snapshot test will therefore compare the new render against the old layout and fail for both tested devices and color schemes; regenerate and commit those full-screen detail baselines after this change.Useful? React with 👍 / 👎.