Skip to content

chore: more verbose Netlify deploy logs - #17057

Merged
teemingc merged 3 commits into
version-3from
teemingc-netlify-deploy-action
Sep 8, 2026
Merged

teemingc merged 3 commits into
version-3from
teemingc-netlify-deploy-action

Conversation

@teemingc

@teemingc teemingc commented Sep 8, 2026 •

Copy link
Copy Markdown
Member

same changes already made on the main branch in #17052

makes deploy logs a bit more verbose

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pkg-svelte-dev

pkg-svelte-dev Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 7ec20d4:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/7ec20d47903b5be12c26fb0249eb85ec508695b3

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17057

@changeset-bot

changeset-bot Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7ec20d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@teemingc teemingc changed the title chore: harden Netlify deploy action chore: more verbose Netlify deploy logs Sep 8, 2026
Comment thread .github/actions/netlify-deploy/action.yml Outdated
@svelte-docs-bot

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: QUIET

Plan: Advanced

Run ID: c5cd76a2-e7cc-4e70-a5fd-05911611d1f8

📥 Commits

Reviewing files that changed from the base of the PR and between 3ecb162 and 7ec20d4.

📒 Files selected for processing (1)
  • .github/actions/netlify-deploy/action.yml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • sveltejs/vite-plugin-svelte (manual)
  • vitejs/vite (manual)
  • sveltejs/svelte (manual)

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The Netlify action now permits esbuild and netlify-cli build scripts during installation. The deployment step enables strict shell execution, reads the application name with jq, and captures deployment JSON. Successful deployments write the URL to GITHUB_OUTPUT. Failed deployments emit an error, print the JSON to stderr, and exit with status 1.

Merge Risk: 🔵 Low · up to 7ec20

Malformed Netlify CLI output can make a deployment run fail without the intended error details, leaving platform-test failures harder to diagnose. This is a bounded CI observability risk.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title uses the required chore: prefix and accurately describes the changes to make Netlify deploy logs more verbose.
Backward Compatibility Impact Disclosure ✅ Passed The pull request changes only the internal implementation of .github/actions/netlify-deploy/action.yml. The three required inputs and the deployment-url output remain unchanged. The diff adds stri…

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Note

Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.

🟡 Other comments (1)
.github/actions/netlify-deploy/action.yml-49-50 (1)

49-50: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win

Handle invalid deployment output explicitly.

If .deploy_url is absent or null, jq -e fails at the assignment on line 49. With set -e, the action exits before it reports the failure or prints deploy_json. jq -e also accepts an empty string. Wrap the extraction in an if statement and validate the URL before writing it to GITHUB_OUTPUT.


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: QUIET

Plan: Advanced

Run ID: b278afb2-1233-442e-8675-033476181596

📥 Commits

Reviewing files that changed from the base of the PR and between 9a4b343 and 3ecb162.

📒 Files selected for processing (1)
  • .github/actions/netlify-deploy/action.yml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • sveltejs/vite-plugin-svelte (manual)
  • vitejs/vite (manual)
  • sveltejs/svelte (manual)

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Comment thread .github/actions/netlify-deploy/action.yml Outdated
Comment thread .github/actions/netlify-deploy/action.yml Outdated
teemingc and others added 2 commits September 8, 2026 16:58
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
@teemingc
teemingc merged commit 49ef97a into version-3 Sep 8, 2026
41 checks passed
@teemingc
teemingc deleted the teemingc-netlify-deploy-action branch September 8, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants