fix(media): don't 500 when the Unsplash/Giphy key is set to null#144
Open
dantaspaulo wants to merge 1 commit into
Open
fix(media): don't 500 when the Unsplash/Giphy key is set to null#144dantaspaulo wants to merge 1 commit into
dantaspaulo wants to merge 1 commit into
Conversation
`config('services.unsplash.access_key', '')` only falls back to '' when the key
is *absent* — if the env var is present but empty, config returns null, and
assigning null to the `string` property throws a TypeError, taking the whole
request down with a 500 during media search.
Cast to `(string)` so a null/empty key degrades gracefully to '' and the service
returns an empty result set (as it already does for a missing key) instead of
throwing.
Covered by a regression test for both services.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
config('services.unsplash.access_key', '')only falls back to''when thekey is absent. If the env var is present but empty,
config()returnsnull, and assigningnullto thestringproperty throws aTypeErrorin theconstructor — taking the whole request down with a 500 during media search.
GiphyServicehas the same issue withservices.giphy.api_key.Fix
Cast to
(string)so a null/empty key degrades gracefully to''. Both servicesalready return an empty result set when the key is empty (
if (empty(...))), sothis restores that intended behavior instead of throwing.
Tests
MediaSearchKeyFallbackTest— constructing each service with anullkey andcalling
search()returns an empty result set without throwing.