Skip to content

fix(media): don't 500 when the Unsplash/Giphy key is set to null #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dantaspaulo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(media): don't 500 when the Unsplash/Giphy key is set to null #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Services/GiphyService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class GiphyService

public function __construct()
{
$this->apiKey = config('services.giphy.api_key', '');
$this->apiKey = (string) config('services.giphy.api_key', '');
}

/**
Expand Down
2 changes: 1 addition & 1 deletion app/Services/UnsplashService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class UnsplashService

public function __construct()
{
$this->accessKey = config('services.unsplash.access_key', '');
$this->accessKey = (string) config('services.unsplash.access_key', '');
}

/**
Expand Down
22 changes: 22 additions & 0 deletions tests/Unit/Services/MediaSearchKeyFallbackTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?php

declare(strict_types=1);

use App\Services\GiphyService;
use App\Services\UnsplashService;

test('unsplash service tolerates a null access key without throwing', function () {
config(['services.unsplash.access_key' => null]);

$result = (new UnsplashService)->search('cats');

expect($result)->toBe(['results' => [], 'total' => 0, 'total_pages' => 0]);
});

test('giphy service tolerates a null api key without throwing', function () {
config(['services.giphy.api_key' => null]);

$result = (new GiphyService)->search('cats');

expect($result)->toBe(['results' => [], 'total' => 0, 'total_pages' => 0]);
});