Prevent grouped ground rails from crossing component rows - #919
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mohan-bee
force-pushed
the
repro/bluetooth-controller-ground-decoupling-groups
branch
from
August 26, 2026 09:13
3d3a625 to
7834c03
Compare
mohan-bee
marked this pull request as draft
August 26, 2026 09:25
mohan-bee
marked this pull request as ready for review
August 26, 2026 15:22
mohan-bee
force-pushed
the
repro/bluetooth-controller-ground-decoupling-groups
branch
from
August 26, 2026 15:22
80e60ed to
9a459ab
Compare
Contributor
Author
|
@copilot rerun ci checks |
Copilot stopped work on behalf of
mohan-bee due to an error
August 26, 2026 15:37
seveibar
approved these changes
Aug 26, 2026
mohan-bee
force-pushed
the
repro/bluetooth-controller-ground-decoupling-groups
branch
from
August 26, 2026 18:05
9a459ab to
ba55734
Compare
mohan-bee
changed the title
Base automatically changed from
repro/bluetooth-controller-ground-decoupling-groups
to
main
August 26, 2026 19:10
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
motivation
the msp stage must use authoritative ground metadata when grouped component rows share one electrical net so it does not create a long cross-row trace through the component groups.
before
the bluetooth reproduction produced 6 ground pairs, including 1 cross-row pair that joined the two local ground rails through the grouped components. this real before schematic svg preserves the crossing.
after
the minimum spanning tree forbids cross-row edges only when typed ground metadata and both grouped rows are present; the result has 5 local pairs and 0 cross-row pairs, while the non-ground control retains 6 pairs and 1 cross-row pair. core #3448 supplies the metadata, the focused tests, type check, build, and all 219 tests pass, and this real after schematic svg shows the separated rows.