fix the bug of global barrier and add the tests that can reproduce the previous bug. - #412
Open
symmetryyyyy wants to merge 4 commits into
Open
fix the bug of global barrier and add the tests that can reproduce the previous bug.#412symmetryyyyy wants to merge 4 commits into
symmetryyyyy wants to merge 4 commits into
Conversation
Add non-deadlocking diagnostics for cross-slot local phase corruption and missing global-barrier phase advancement. Register both tests in the aggregate regression suite and explicit SimX/xrtsim smoke coverage. Co-Authored-By: RunjiaChen <runjia@u.nus.edu> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Capture the phase and exact waiters for each pending global-barrier generation, queue completed local arrivals, and route each cluster response directly to its barrier slot. Keep response-only writes out of the barrier state RAM and qualify the working phase bypass by address. Use one-bit phase toggles in SimX so wait comparisons keep matching the RTL after wraparound.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 Add a regression test to reproduce the previous bug: introduce gbar_phase, a two-core SimX/RTLSim test that reproduces the global-barrier response-phase bug and verifies phase advancement across completed generations.
2 Enhance asynchronous stress coverage: extend the split arrive/wait loop in async_gbarrier from 32 to 1024 iterations, making delayed responses and phase reuse observable.
3 Restructure global-barrier response handling: replace the single pending-request state with per-barrier pending/phase/waiter bookkeeping and a request FIFO, so responses are matched by barrier ID and routed to the correct phase and waiting warps.