[eas-build-job][build-tools][steps] Accept legacy command/path custom function shape in function.yml; rename references in the consumers - #4095
Conversation
e893fae to
3b018d6
Compare
3b018d6 to
891ef23
Compare
891ef23 to
27f53d7
Compare
27f53d7 to
e8d69a0
Compare
e8d69a0 to
702bea2
Compare
961f32c to
9d5f159
Compare
9d5f159 to
36a1945
Compare
b98bbfd to
a241370
Compare
a241370 to
d957ecb
Compare
d957ecb to
ef13e90
Compare
🤖 AI code reviewDecision: Approve with comments Overall PR risk: Low. The change is additive: it adds new Zod schemas ( 🟡 Warning (1)
This review is advisory — it never blocks a merge and never auto-approves. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4095 +/- ##
==========================================
+ Coverage 62.47% 62.48% +0.02%
==========================================
Files 1008 1010 +2
Lines 45778 45796 +18
Branches 9632 9633 +1
==========================================
+ Hits 28596 28613 +17
- Misses 15721 15722 +1
Partials 1461 1461 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ef13e90 to
ca56231
Compare
975902e to
6faae3b
Compare
6faae3b to
709f6de
Compare
709f6de to
fb38166
Compare
c006824 to
abf928e
Compare
abf928e to
c4b9c7b
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Why
We want to grandfather the legacy reusable functions from custom builds (https://docs.expo.dev/custom-builds/functions/) into the new reusable functions that can be used in workflows. This is to make the migration from custom builds to workflows easier.
Currently, we only support composite functions. The first step towards extending the support is modifying the
eas-build-jobZod schema.How
legacyFunctionmodule with Zod schemas to match the legacy custom builds functions.LegacyCommandFunctionConfigZ(functions withcommand:present) andLegacyPathFunctionConfigZ(functions withpath:present).compositeFunctionand created a newlocalFunctionmodule with schema that is a union of composite function schema and legacy function schemas.stepsandbuild-toolsthat should reference "local functions".Test Plan
Added unit tests.