Skip to content

[build-tools] Load legacy command/path local functions and resolve module paths - #4097

Closed
sswrk wants to merge 6 commits into
szymonswierk/eng-25402-steps-expand-legacy-functionsfrom
szymonswierk/eng-25402-build-tools-load-legacy-functions
Closed

[build-tools] Load legacy command/path local functions and resolve module paths#4097
sswrk wants to merge 6 commits into
szymonswierk/eng-25402-steps-expand-legacy-functionsfrom
szymonswierk/eng-25402-build-tools-load-legacy-functions

Conversation

@sswrk

@sswrk sswrk commented Jul 27, 2026

Copy link
Copy Markdown
Member

Why

How

Test Plan

@linear-code

linear-code Bot commented Jul 27, 2026

Copy link
Copy Markdown

ENG-25402

sswrk commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (szymonswierk/eng-25402-steps-expand-legacy-functions@efa0f83). Learn more about missing BASE report.

Additional details and impacted files
@@                                   Coverage Diff                                   @@
##             szymonswierk/eng-25402-steps-expand-legacy-functions    #4097   +/-   ##
=======================================================================================
  Coverage                                                        ?   62.48%           
=======================================================================================
  Files                                                           ?     1011           
  Lines                                                           ?    45782           
  Branches                                                        ?     9635           
=======================================================================================
  Hits                                                            ?    28601           
  Misses                                                          ?    15721           
  Partials                                                        ?     1460           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch from 6ce77e0 to c468e34 Compare July 28, 2026 09:04
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch from b77819d to b43b302 Compare July 28, 2026 09:04
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch from c468e34 to d2e8524 Compare July 28, 2026 12:58
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch from 22be929 to a49aa69 Compare July 28, 2026 13:11
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch 2 times, most recently from 5554d33 to 76e0f68 Compare July 28, 2026 15:30
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch 2 times, most recently from 0df6118 to 2e32e71 Compare July 29, 2026 09:01
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch from 76e0f68 to 2da65a9 Compare July 29, 2026 09:01
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch from 2e32e71 to 3ba680d Compare July 29, 2026 09:29
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch 2 times, most recently from d1cc5f1 to 548b648 Compare July 29, 2026 13:40
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch from 3ba680d to 096a5fd Compare July 29, 2026 13:40
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch from 548b648 to 3155e8c Compare July 30, 2026 15:09
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch from 096a5fd to 04ebb71 Compare July 30, 2026 15:09
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch from 4d514bb to 6a383b7 Compare August 4, 2026 09:45
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch 2 times, most recently from 4d0bed9 to c93260f Compare August 4, 2026 11:45
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch from 6a383b7 to a87d8c5 Compare August 4, 2026 11:45
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch from c93260f to 67528ed Compare August 4, 2026 13:32
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch from a87d8c5 to 35bad0f Compare August 4, 2026 13:32
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch from 67528ed to 73f16b2 Compare August 4, 2026 14:22
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch from 35bad0f to 04f6452 Compare August 4, 2026 14:22
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch from 73f16b2 to f5e2967 Compare August 4, 2026 15:34
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch 2 times, most recently from 162e2de to 104fbe6 Compare August 5, 2026 10:19
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch from f5e2967 to 480761d Compare August 5, 2026 10:19
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch 2 times, most recently from 80f712a to 80d6d47 Compare August 5, 2026 10:38
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch 2 times, most recently from 1f539b2 to 5ce09c7 Compare August 5, 2026 10:58
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch from 80d6d47 to 0486baf Compare August 5, 2026 10:58
sswrk added 6 commits August 5, 2026 13:11
A local function can now be a composite function or a single-step
command/path function, so the "composite function" naming throughout
packages/steps (and its build-tools/eas-cli consumers) is renamed to
the more general "local function". Pure rename: no behavior, wording,
or type changes.
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch from 0486baf to efa0f83 Compare August 5, 2026 11:14
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch from 5ce09c7 to 6d90005 Compare August 5, 2026 11:14
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch from efa0f83 to 51743d5 Compare August 5, 2026 12:05
@sswrk sswrk closed this Aug 5, 2026
@sswrk

sswrk commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

Folding into #4096

@sswrk
sswrk deleted the szymonswierk/eng-25402-build-tools-load-legacy-functions branch August 5, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant