Skip to content

[eas-cli] Validate legacy command/path local functions referenced from workflows - #4098

Closed
sswrk wants to merge 1 commit into
szymonswierk/eng-25402-steps-expand-legacy-functionsfrom
szymonswierk/eng-25402-eas-cli-validate-legacy-functions
Closed

[eas-cli] Validate legacy command/path local functions referenced from workflows#4098
sswrk wants to merge 1 commit into
szymonswierk/eng-25402-steps-expand-legacy-functionsfrom
szymonswierk/eng-25402-eas-cli-validate-legacy-functions

Conversation

@sswrk

@sswrk sswrk commented Jul 27, 2026

Copy link
Copy Markdown
Member

Why

How

Test Plan

@linear-code

linear-code Bot commented Jul 27, 2026

Copy link
Copy Markdown

ENG-25402

sswrk commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sswrk
sswrk force-pushed the szymonswierk/eng-25402-eas-cli-validate-legacy-functions branch from 76ac6a7 to c1e1802 Compare July 27, 2026 15:02
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch from 34f9038 to 6ce77e0 Compare July 27, 2026 15:02
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (szymonswierk/eng-25402-steps-expand-legacy-functions@5b53032). Learn more about missing BASE report.

Additional details and impacted files
@@                                   Coverage Diff                                   @@
##             szymonswierk/eng-25402-steps-expand-legacy-functions    #4098   +/-   ##
=======================================================================================
  Coverage                                                        ?   62.52%           
=======================================================================================
  Files                                                           ?     1011           
  Lines                                                           ?    45832           
  Branches                                                        ?     9645           
=======================================================================================
  Hits                                                            ?    28651           
  Misses                                                          ?    15720           
  Partials                                                        ?     1461           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch from 6ce77e0 to c468e34 Compare July 28, 2026 09:04
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-eas-cli-validate-legacy-functions branch 2 times, most recently from 71cf625 to a0450ff Compare July 28, 2026 12:58
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch 2 times, most recently from d2e8524 to 5554d33 Compare July 28, 2026 13:11
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-eas-cli-validate-legacy-functions branch from a0450ff to c3d3b6d Compare July 28, 2026 13:11
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch from 5554d33 to 76e0f68 Compare July 28, 2026 15:30
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-eas-cli-validate-legacy-functions branch 2 times, most recently from 7b0c93a to b053726 Compare July 29, 2026 09:01
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch from 2da65a9 to d1cc5f1 Compare July 29, 2026 09:29
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-eas-cli-validate-legacy-functions branch 2 times, most recently from b91cd16 to e34b99c Compare July 29, 2026 13:40
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch from d1cc5f1 to 548b648 Compare July 29, 2026 13:40
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-eas-cli-validate-legacy-functions branch from e34b99c to f38683e Compare July 30, 2026 15:09
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch 2 times, most recently from f5e2967 to 480761d Compare August 5, 2026 10:19
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-eas-cli-validate-legacy-functions branch 3 times, most recently from ef29f76 to a0f8fa7 Compare August 5, 2026 10:58
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch from 1f539b2 to 5ce09c7 Compare August 5, 2026 10:58
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-eas-cli-validate-legacy-functions branch from a0f8fa7 to 9549b57 Compare August 5, 2026 11:14
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-build-tools-load-legacy-functions branch from 5ce09c7 to 6d90005 Compare August 5, 2026 11:14
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-eas-cli-validate-legacy-functions branch from 9549b57 to f00eaae Compare August 5, 2026 12:08
@sswrk
sswrk changed the base branch from szymonswierk/eng-25402-build-tools-load-legacy-functions to szymonswierk/eng-25402-steps-expand-legacy-functions August 5, 2026 12:10
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch from 51743d5 to 2e21d7e Compare August 5, 2026 12:14
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-eas-cli-validate-legacy-functions branch from f00eaae to 7432564 Compare August 5, 2026 12:14
@sswrk sswrk added the ai-review Commits pushed to PRs with this label be automatically reviewed. label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

🤖 AI code review

Decision: Approve

Overall PR risk: Low. The change is additive: it adds one test case to the validateWorkflowLocalFunctionsAsync suite and one CHANGELOG line. No product source files change. The new test only writes a function.yml fixture and checks that validation resolves; it does not run any command or touch credentials or network calls. If this PR breaks anything, it would break the CI test suite, not a user-facing command. No reviewer reported a correctness, security, or consistency issue.

No findings.


This review is advisory — it never blocks a merge and never auto-approves.

@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch from 2e21d7e to d544e0c Compare August 5, 2026 12:29
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-eas-cli-validate-legacy-functions branch 2 times, most recently from 5822696 to ade9b4e Compare August 5, 2026 12:47
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch 2 times, most recently from b0d5a61 to 127baa7 Compare August 5, 2026 13:26
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-eas-cli-validate-legacy-functions branch 2 times, most recently from 1769988 to 06f5d4e Compare August 5, 2026 15:01
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch from 127baa7 to 316a9b7 Compare August 5, 2026 15:01
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-eas-cli-validate-legacy-functions branch from 06f5d4e to b48d009 Compare August 5, 2026 15:15
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch from 316a9b7 to d4e75da Compare August 5, 2026 15:15
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-eas-cli-validate-legacy-functions branch from b48d009 to f6df48c Compare August 6, 2026 12:25
@sswrk
sswrk force-pushed the szymonswierk/eng-25402-steps-expand-legacy-functions branch from d4e75da to 5b53032 Compare August 6, 2026 12:25
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@sswrk

sswrk commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

Folding into #4096: this PR only added test coverage and a CHANGELOG entry for functionality already delivered in #4096. See the folded commit on that branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Commits pushed to PRs with this label be automatically reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant