added ascii rick roll in terminal instead of opening gif in new window - #84
Closed
ophiuchus44 wants to merge 1 commit into
Closed
added ascii rick roll in terminal instead of opening gif in new window#84ophiuchus44 wants to merge 1 commit into
ophiuchus44 wants to merge 1 commit into
Conversation
3 tasks
ledwards
added a commit
that referenced
this pull request
Aug 13, 2026
* Land three stalled command contributions, and finish the RickRoll move Four PRs sat open for between one and four years. The ideas were good; the patches had rotted against a file that moved underneath them. Reapplied here with credit. - cowsay (#106) — prints the classic bubble and cow. Uses writeln rather than stylePrint because it is alignment-sensitive art that stylePrint would wrap and recolor. - date and wget (#72) — date prints the real thing; wget points at curl, which already has the joke response. - The RickRoll (#84, #85). Both PRs wanted the joke to play in the terminal instead of punting the user to an imgur GIF in a new tab. That landed for `test` at some point, but `cat id_rsa`, `grep <pattern> id_rsa` and `open test.htm` were left behind still opening the GIF. All four now go through one _rickRoll() helper, so they cannot drift apart again. Verified in a browser against a built dist/: cowsay renders correctly, date and wget print as expected, and all four RickRoll routes fire the in-terminal animation with zero external URLs opened. Co-Authored-By: mantra-1 <mantra-1@users.noreply.github.com> Co-Authored-By: nkulkarni <nkulkarni@users.noreply.github.com> Co-Authored-By: ophiuchus44 <ophiuchus44@users.noreply.github.com> Co-Authored-By: jandobrx <jandobrx@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Add cd test coverage, ported from #51 cd is the one command with real branching — a switch over ~, .., /home, /bin and team member names, several branches of which recurse through term.command — and it drives term.cwd, which the prompt renders on every keystroke. It had no tests. The table comes from #51 (@astonm, November 2021), which never landed. Its harness is long gone, but every case it asserted still describes the intended behaviour, so the table is ported onto the current vitest setup and extended with the permission-denied and unknown-directory paths. Co-Authored-By: astonm <astonm@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: mantra-1 <mantra-1@users.noreply.github.com> Co-authored-by: nkulkarni <nkulkarni@users.noreply.github.com> Co-authored-by: ophiuchus44 <ophiuchus44@users.noreply.github.com> Co-authored-by: jandobrx <jandobrx@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: astonm <astonm@users.noreply.github.com>
Contributor
|
Landed in #134, with credit to you in the commit. Your read was right and still half-true when I got to it: the in-terminal RickRoll existed for The one thing that didn't carry over is the mechanism — rather than shelling out to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why open a new window to a gif/video when you could play an ascii version of rick roll in terminal!!!
ascii_rroll.mov