[ci] Validate all inputs before CI planning - #3579
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gocqawbn3p3zj7xyfo7etk6vo4633r3tn #3579 +/- ##
====================================================================
Coverage ? 91.85%
====================================================================
Files ? 20
Lines ? 6093
Branches ? 0
====================================================================
Hits ? 5597
Misses ? 496
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5070ce3 to
fac6e43
Compare
bdc8039 to
16d8463
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
16d8463 to
aeefea6
Compare
fac6e43 to
77f85fe
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4cdca490a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1efd245 to
205aa5e
Compare
d4cdca4 to
20eff57
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
205aa5e to
467e8ab
Compare
20eff57 to
18f67fd
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
467e8ab to
ce33423
Compare
18f67fd to
c5520b4
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
c5520b4 to
d916ace
Compare
ce33423 to
6cc20d1
Compare
d916ace to
d57f111
Compare
6cc20d1 to
b3a0666
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d57f111ce1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d57f111 to
9b3d33e
Compare
0128ac8 to
1e67168
Compare
9b3d33e to
30011a4
Compare
Add one loading boundary which reads the typed policy, audits live Cargo metadata and repository files, inventories every workflow job, and strictly parses the frozen legacy baseline. Return planning inputs only after every layer succeeds. Wiring the workflow audit here also removes the temporary unused-code allowance from its introductory commit. This keeps future planners from depending on call order or accidentally skipping a validation pass. It also keeps the policy-owned baseline paths in one place rather than repeating their coordination in each consumer. Resolve each input through the canonical repository boundary before opening it. Reject baseline roles which identify the same underlying file even when their policy spellings differ through symlinks or hard links, so supposedly independent review evidence cannot silently alias. Cross-platform open handles keep each identity stable for the complete comparison. Tests: CARGO_NET_OFFLINE=true ./ci/check_tools.sh Tests: ./ci/check_fmt.sh *Authored by an agent, posting via joshlf's account* gherrit-pr-id: Gsizgstaatljzyuwyc4tp4ha6krvibz64
1e67168 to
c87afd9
Compare
30011a4 to
854f7f6
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Add one loading boundary which reads the typed policy, audits live Cargo
metadata and repository files, inventories every workflow job, and
strictly parses the frozen legacy baseline. Return planning inputs only
after every layer succeeds. Wiring the workflow audit here also removes
the temporary unused-code allowance from its introductory commit.
This keeps future planners from depending on call order or accidentally
skipping a validation pass. It also keeps the policy-owned baseline
paths in one place rather than repeating their coordination in each
consumer.
Resolve each input through the canonical repository boundary before
opening it. Reject baseline roles which identify the same underlying
file even when their policy spellings differ through symlinks or hard
links, so supposedly independent review evidence cannot silently alias.
Cross-platform open handles keep each identity stable for the complete
comparison.
Tests: CARGO_NET_OFFLINE=true ./ci/check_tools.sh
Tests: ./ci/check_fmt.sh
Authored by an agent, posting via joshlf's account
Latest Update: v29 — Compare vs v28
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gsizgstaatljzyuwyc4tp4ha6krvibz64 && git checkout -b pr-Gsizgstaatljzyuwyc4tp4ha6krvibz64 FETCH_HEADCheckout
git fetch origin refs/heads/Gsizgstaatljzyuwyc4tp4ha6krvibz64 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gsizgstaatljzyuwyc4tp4ha6krvibz64 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.