[ci] Execute exact typed matrix cells - #3589
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97e206f4a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gnp4lv6jrqbhnp5pyd2625o7jwdguulmz #3589 +/- ##
==================================================================
Coverage 91.85% 91.85%
==================================================================
Files 20 20
Lines 6093 6093
==================================================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
08414d4 to
d206edd
Compare
97e206f to
5527487
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 552748717a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
5527487 to
7bb8725
Compare
d206edd to
483b00c
Compare
8cb3a1e to
7fd0482
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
662029c to
c719e07
Compare
7fd0482 to
943b0c0
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
943b0c0 to
99b8cd8
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
25c4bbd to
e2d9f7c
Compare
99b8cd8 to
239ae55
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
e2d9f7c to
bad5c53
Compare
85ecd5e to
f47a484
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2238a9b to
fa4256b
Compare
ab1aedd to
e7cd2ac
Compare
fa4256b to
5ceb1a6
Compare
The typed planner previously stopped after describing intended work. Add exact build and Miri selectors, and execute every local Cargo step from the already-audited command model. Each invocation replans the named event and requires one complete cell match, so stale, partial, or newly ambiguous matrix data fails before a process starts. Commands remain argv vectors; policy values never pass through shell parsing. Keep the platform-neutral model in terms of cargo.sh, but translate that exact wrapper to win-cargo.bat at the real Windows host boundary. This preserves one set of plans and goldens while making native Windows cells execute the reviewed platform entry point. Run Miri from the repository root without moving its Cargo config. Add the explicit zerocopy manifest at the executor boundary, then use one private, exact-valued context to change only the wrapper's Cargo child. This preserves toolchain installation, wrapper flags, package qualification, and target directories while making concurrent and cancelled cells incapable of leaving the checkout modified. Retain GNU nproc and its OMP behavior on Linux. Use Rust's available parallelism on other hosts, and check the multiplication on every host. The semver action remains workflow-owned because GitHub requires a literal uses step. Correct the nightly documentation golden to include the RUSTFLAGS and MIRIFLAGS which the current workflow actually inherits. Tests: ci/check_tools.sh Tests: cargo clippy -p zc --all-targets --offline -- -D warnings *Authored by an agent, posting via joshlf's account* gherrit-pr-id: Gbsj7gxuv5hpi22zhup5w3fajtjjxnldj
5ceb1a6 to
dfc8b9d
Compare
e7cd2ac to
b3c77b4
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
The typed planner previously stopped after describing intended work.
Add exact build and Miri selectors, and execute every local Cargo step
from the already-audited command model.
Each invocation replans the named event and requires one complete cell
match, so stale, partial, or newly ambiguous matrix data fails before a
process starts. Commands remain argv vectors; policy values never pass
through shell parsing.
Keep the platform-neutral model in terms of cargo.sh, but translate that
exact wrapper to win-cargo.bat at the real Windows host boundary. This
preserves one set of plans and goldens while making native Windows cells
execute the reviewed platform entry point.
Run Miri from the repository root without moving its Cargo config. Add
the explicit zerocopy manifest at the executor boundary, then use one
private, exact-valued context to change only the wrapper's Cargo child.
This preserves toolchain installation, wrapper flags, package
qualification, and target directories while making concurrent and
cancelled cells incapable of leaving the checkout modified.
Retain GNU nproc and its OMP behavior on Linux. Use Rust's available
parallelism on other hosts, and check the multiplication on every host.
The semver action remains workflow-owned because GitHub requires a
literal uses step.
Correct the nightly documentation golden to include the RUSTFLAGS and
MIRIFLAGS which the current workflow actually inherits.
Tests: ci/check_tools.sh
Tests: cargo clippy -p zc --all-targets --offline -- -D warnings
Authored by an agent, posting via joshlf's account
Latest Update: v29 — Compare vs v28
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gbsj7gxuv5hpi22zhup5w3fajtjjxnldj && git checkout -b pr-Gbsj7gxuv5hpi22zhup5w3fajtjjxnldj FETCH_HEADCheckout
git fetch origin refs/heads/Gbsj7gxuv5hpi22zhup5w3fajtjjxnldj && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gbsj7gxuv5hpi22zhup5w3fajtjjxnldj && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.