Skip to content

[ci] Read docs.rs arguments from Cargo metadata - #3585

Open
joshlf wants to merge 1 commit into
Gx6vwydb7e2ijorcpxmqt3axxviika37lfrom
Getgur4i3su6l2xcpgewl2bbvcskszm5r
Open

[ci] Read docs.rs arguments from Cargo metadata#3585
joshlf wants to merge 1 commit into
Gx6vwydb7e2ijorcpxmqt3axxviika37lfrom
Getgur4i3su6l2xcpgewl2bbvcskszm5r

Conversation

@joshlf

@joshlf joshlf commented Aug 25, 2026

Copy link
Copy Markdown
Member

The nightly documentation command must include the exact Rustdoc
arguments that docs.rs uses. Keeping another list in the command model
would let the two copies drift.

Read the ordered arguments from the canonical Zerocopy package
selected by CI policy. Reject missing or malformed metadata, ownership
by the wrong package, and values whose argument boundaries the current
RUSTDOCFLAGS transport cannot preserve. Expose only checked arguments
to later planning code.

Tests: cargo test -p zc --all-targets
cargo clippy -p zc --all-targets --offline -- -D warnings

Authored by an agent, posting via joshlf's account


Latest Update: v29 — Compare vs v28

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v29 v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v28 v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v27 v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v26 v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v25 v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v24 v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v23 v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v22 v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v21 v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v20 v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v19 v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v8 v7 v6 v5 v4 v3 v2 v1 Base
v7 v6 v5 v4 v3 v2 v1 Base
v6 v5 v4 v3 v2 v1 Base
v5 v4 v3 v2 v1 Base
v4 v3 v2 v1 Base
v3 v2 v1 Base
v2 v1 Base
v1 Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Getgur4i3su6l2xcpgewl2bbvcskszm5r && git checkout -b pr-Getgur4i3su6l2xcpgewl2bbvcskszm5r FETCH_HEAD

Checkout

git fetch origin refs/heads/Getgur4i3su6l2xcpgewl2bbvcskszm5r && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Getgur4i3su6l2xcpgewl2bbvcskszm5r && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Getgur4i3su6l2xcpgewl2bbvcskszm5r

Stacked PRs enabled by GHerrit.

@codecov-commenter

codecov-commenter commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (Gx6vwydb7e2ijorcpxmqt3axxviika37l@5ea2766). Learn more about missing BASE report.

Additional details and impacted files
@@                         Coverage Diff                          @@
##             Gx6vwydb7e2ijorcpxmqt3axxviika37l    #3585   +/-   ##
====================================================================
  Coverage                                     ?   91.85%           
====================================================================
  Files                                        ?       20           
  Lines                                        ?     6093           
  Branches                                     ?        0           
====================================================================
  Hits                                         ?     5597           
  Misses                                       ?      496           
  Partials                                     ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

joshlf commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 4797a985a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@joshlf
joshlf force-pushed the Getgur4i3su6l2xcpgewl2bbvcskszm5r branch from a68ba4a to e9352c2 Compare August 26, 2026 15:46
@joshlf

joshlf commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: e9352c234e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@joshlf
joshlf force-pushed the Getgur4i3su6l2xcpgewl2bbvcskszm5r branch from e9352c2 to bec75d1 Compare August 26, 2026 17:40
@joshlf
joshlf force-pushed the Gx6vwydb7e2ijorcpxmqt3axxviika37l branch from 23c7af1 to 9940ac1 Compare August 26, 2026 17:40
@joshlf

joshlf commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: bec75d1145

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@joshlf
joshlf force-pushed the Getgur4i3su6l2xcpgewl2bbvcskszm5r branch from bec75d1 to eb2e036 Compare August 26, 2026 18:55
@joshlf

joshlf commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

@codex review

Please review the current head, eb2e036014d84b4725a4df8489c1861b43f23837.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: eb2e036014

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@joshlf
joshlf force-pushed the Getgur4i3su6l2xcpgewl2bbvcskszm5r branch from eb2e036 to e663714 Compare August 26, 2026 20:11
@joshlf

joshlf commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

@codex review

Please review the current head, e663714189fd5cc07c45cde713922c14bc881e28.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: e663714189

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@joshlf
joshlf force-pushed the Gx6vwydb7e2ijorcpxmqt3axxviika37l branch from 3073096 to f7b052c Compare August 26, 2026 22:09
@joshlf
joshlf force-pushed the Getgur4i3su6l2xcpgewl2bbvcskszm5r branch from e663714 to 10de534 Compare August 26, 2026 22:09
@joshlf
joshlf force-pushed the Gx6vwydb7e2ijorcpxmqt3axxviika37l branch from f7b052c to fe6e3ac Compare August 26, 2026 22:35
@joshlf
joshlf force-pushed the Getgur4i3su6l2xcpgewl2bbvcskszm5r branch from 10de534 to 517c46a Compare August 26, 2026 22:35
@joshlf

joshlf commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

@codex review

Please review the current head, 517c46ae582ddbf961584e607754f4f2a36cadb0.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 517c46ae58

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@joshlf
joshlf force-pushed the Gx6vwydb7e2ijorcpxmqt3axxviika37l branch from fe6e3ac to bee291c Compare August 26, 2026 23:31
@joshlf
joshlf force-pushed the Getgur4i3su6l2xcpgewl2bbvcskszm5r branch 2 times, most recently from 1f30180 to 58c3a2a Compare August 27, 2026 01:18
@joshlf
joshlf force-pushed the Gx6vwydb7e2ijorcpxmqt3axxviika37l branch from bee291c to 5ea2766 Compare August 27, 2026 01:18
The nightly documentation command must include the exact Rustdoc
arguments that docs.rs uses. Keeping another list in the command model
would let the two copies drift.

Read the ordered arguments from the canonical Zerocopy package
selected by CI policy. Reject missing or malformed metadata, ownership
by the wrong package, and values whose argument boundaries the current
RUSTDOCFLAGS transport cannot preserve. Expose only checked arguments
to later planning code.

Tests: cargo test -p zc --all-targets
       cargo clippy -p zc --all-targets --offline -- -D warnings

*Authored by an agent, posting via joshlf's account*

gherrit-pr-id: Getgur4i3su6l2xcpgewl2bbvcskszm5r
@joshlf
joshlf force-pushed the Gx6vwydb7e2ijorcpxmqt3axxviika37l branch from 5ea2766 to 55b1919 Compare August 27, 2026 10:15
@joshlf
joshlf force-pushed the Getgur4i3su6l2xcpgewl2bbvcskszm5r branch from 58c3a2a to 223dfa4 Compare August 27, 2026 10:15
@joshlf

joshlf commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

@codex review

Please review the current head, 223dfa4dab039fa8b1325aeea4520acc274d34c5.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 223dfa4dab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants