[ci] Harden typed feature coverage - #3560
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## G6vtk5f2delygb2de3ctuojmcdbyuolw3 #3560 +/- ##
==================================================================
Coverage 91.85% 91.85%
==================================================================
Files 20 20
Lines 6093 6093
==================================================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7e334e1fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Authored by Codex, posting via joshlf's account @codex review Please review the current exact head after the stack reorder and recovery. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
f7e334e to
3d2f255
Compare
833763e to
f0a180e
Compare
|
Authored by Codex, posting via joshlf's account @codex review Please review the current exact head after addressing the prior feedback. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Require the canonical UI integration target to keep its exact derive gate and remain enabled by the stable feature profile. Derive every integration target's eligible semantic feature profiles from Cargo metadata. Require each enabled package/profile pair to own a native test cell for both pull requests and full CI, using only the canonical MSRV, stable, or nightly toolchains. This prevents valid but unreachable required-features or compile-only coverage from silently passing the inventory audit. Run the testutil unit tests from check_tools so the decoder for recursive UI feature forwarding is exercised beside cargo-zerocopy's encoder. The Miri models already run in parallel through the typed planner; this reconstruction keeps the remaining feature guarantees in Rust instead of restoring the superseded shell policy. *Authored by an agent, posting via joshlf's account* gherrit-pr-id: G386fde8c9c2d7c96a9f67f5f5a0f5a64
3d2f255 to
5b71dd8
Compare
joshlf
changed the title
|
Authored by an agent, posting via joshlf's account @jswrenn, the current revision replaces the reviewed shell, Python, and workflow implementation with typed Rust inventory checks and focused Rust tests. The four inline threads have now been addressed or made obsolete by that rewrite. Would you please re-review current head 5b71dd8? |
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
3 participants
Require the canonical UI integration target to keep its exact derive
gate and remain enabled by the stable feature profile.
Derive every integration target's eligible semantic feature profiles
from Cargo metadata. Require each enabled package/profile pair to own a
native test cell for both pull requests and full CI, using only the
canonical MSRV, stable, or nightly toolchains. This prevents valid but
unreachable required-features or compile-only coverage from silently
passing the inventory audit.
Run the testutil unit tests from check_tools so the decoder for
recursive UI feature forwarding is exercised beside cargo-zerocopy's
encoder. The Miri models already run in parallel through the typed
planner; this reconstruction keeps the remaining feature guarantees in
Rust instead of restoring the superseded shell policy.
Authored by an agent, posting via joshlf's account
Latest Update: v7 — Compare vs v6
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G386fde8c9c2d7c96a9f67f5f5a0f5a64 && git checkout -b pr-G386fde8c9c2d7c96a9f67f5f5a0f5a64 FETCH_HEADCheckout
git fetch origin refs/heads/G386fde8c9c2d7c96a9f67f5f5a0f5a64 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G386fde8c9c2d7c96a9f67f5f5a0f5a64 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.