[ci] Audit typed jobs into the required check - #3595
Conversation
4ebd94a to
b221e68
Compare
3143da8 to
89b8771
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
08726ef to
762a0dc
Compare
b221e68 to
4d1e30f
Compare
e2e5b8b to
96d41c3
Compare
6a81fe4 to
5c8b678
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
5c8b678 to
ec0310e
Compare
18f1d3f to
ad789f3
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
30dcd81 to
b8fe2df
Compare
336e4ee to
bb95028
Compare
a083de6 to
da22c8c
Compare
bb95028 to
c32e32b
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
da22c8c to
6f9c0bc
Compare
c32e32b to
18987e0
Compare
6f9c0bc to
545c5e9
Compare
18987e0 to
40e01ca
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Audit the all-jobs-succeed behavior established by the typed plan and semver integration. Require its exact top-level shape, externally configured display name, empty permissions, hosted runner, always-run condition, and minimum direct path from plan_ci, build_test, miri, semver, and the job dependency audit. Audit the exact ordered cancellation guard and require all five planner outputs to be present before final aggregation. Treat Miri and semver as the only optional jobs: each may be skipped exactly when its checked enable output is false and must succeed when enabled. Match the total skipped dependency count to those disabled jobs so no unrelated skip can pass. Reject extra privileged steps, and require exact environments, custom Bash, and the absolute jq run block. On Linux, execute that exact Bash and jq program against a truth table covering both optional jobs enabled and disabled. Reject enabled skips, disabled successes, unrelated skips, failures, cancellations, malformed results JSON, and invalid gates so the source audit and runtime meaning cannot drift independently. Normalize the aggregate YAML indentation and document that its display name must stay coordinated with the external branch-protection or ruleset setting. Tests: offline zc tests Tests: zc clippy with warnings denied Tests: ci/check_actions.sh Tests: cargo.sh ci audit Tests: ci/check_fmt.sh Tests: git diff --check *Authored by an agent, posting via joshlf's account* gherrit-pr-id: Gnouzrlnq3bnxeg72jfe7d3xq6jymqqcf
545c5e9 to
985bbcd
Compare
40e01ca to
3d017fb
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Audit the all-jobs-succeed behavior established by the typed plan and
semver integration. Require its exact top-level shape, externally
configured display name, empty permissions, hosted runner, always-run
condition, and minimum direct path from plan_ci, build_test, miri,
semver, and the job dependency audit.
Audit the exact ordered cancellation guard and require all five planner
outputs to be present before final aggregation. Treat Miri and semver as
the only optional jobs: each may be skipped exactly when its checked
enable output is false and must succeed when enabled. Match the total
skipped dependency count to those disabled jobs so no unrelated skip can
pass. Reject extra privileged steps, and require exact environments,
custom Bash, and the absolute jq run block.
On Linux, execute that exact Bash and jq program against a truth table
covering both optional jobs enabled and disabled. Reject enabled skips,
disabled successes, unrelated skips, failures, cancellations, malformed
results JSON, and invalid gates so the source audit and runtime meaning
cannot drift independently.
Normalize the aggregate YAML indentation and document that its display
name must stay coordinated with the external branch-protection or
ruleset setting.
Tests: offline zc tests
Tests: zc clippy with warnings denied
Tests: ci/check_actions.sh
Tests: cargo.sh ci audit
Tests: ci/check_fmt.sh
Tests: git diff --check
Authored by an agent, posting via joshlf's account
Latest Update: v29 — Compare vs v28
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gnouzrlnq3bnxeg72jfe7d3xq6jymqqcf && git checkout -b pr-Gnouzrlnq3bnxeg72jfe7d3xq6jymqqcf FETCH_HEADCheckout
git fetch origin refs/heads/Gnouzrlnq3bnxeg72jfe7d3xq6jymqqcf && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gnouzrlnq3bnxeg72jfe7d3xq6jymqqcf && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.